From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 06DDD633838 for ; Thu, 12 May 2016 09:52:06 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH] git-http-backend: do not drop connection on successful finish Date: Thu, 12 May 2016 09:52:05 +0000 Message-Id: <20160512095205.6139-3-e@80x24.org> In-Reply-To: <20160512095205.6139-1-e@80x24.org> References: <20160512095205.6139-1-e@80x24.org> List-Id: We can maintain the client HTTP connection if the process exited with failure as long as we terminated our own response properly. --- lib/PublicInbox/GitHTTPBackend.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm index 020b088..abb70df 100644 --- a/lib/PublicInbox/GitHTTPBackend.pm +++ b/lib/PublicInbox/GitHTTPBackend.pm @@ -259,10 +259,7 @@ sub serve_smart { if (defined $pid) { my $e = $pid == waitpid($pid, 0) ? $? : "PID:$pid still running?"; - if ($e) { - err($env, "git http-backend ($git_dir): $e"); - drop_client($env); - } + err($env, "git http-backend ($git_dir): $e") if $e; } return unless $res; my $dumb = serve_dumb($cgi, $git, $path);