* [PATCH] mda: reject multiple Message-IDs up front
@ 2016-04-21 22:49 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-04-21 22:49 UTC (permalink / raw)
To: meta
While ssoma now documents it uses the first Message-ID, they
are confusing and could be a sign of a broken mail software,
and broken mail software is often a sign of spam...
ref: http://public-inbox.org/meta/20160421221128.4910-1-e@80x24.org/
---
lib/PublicInbox/MDA.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/MDA.pm b/lib/PublicInbox/MDA.pm
index 003bac6..26681c2 100644
--- a/lib/PublicInbox/MDA.pm
+++ b/lib/PublicInbox/MDA.pm
@@ -23,7 +23,9 @@ sub __drop_plus {
sub precheck {
my ($klass, $filter, $address) = @_;
my Email::Simple $simple = $filter->simple;
- my $mid = $simple->header("Message-ID");
+ my @mid = $simple->header('Message-ID');
+ return 0 if scalar(@mid) != 1;
+ my $mid = $mid[0];
return 0 if (length($mid) > MAX_MID_SIZE);
return 0 unless usable_str(length('<m@h>'), $mid) && $mid =~ /\@/;
return 0 unless usable_str(length('u@h'), $filter->from);
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-04-21 22:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 22:49 [PATCH] mda: reject multiple Message-IDs up front Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).