* [PATCH] view: fix linkification and quote-folding conflicts
@ 2015-03-04 20:52 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-03-04 20:52 UTC (permalink / raw)
To: meta
We can't add newlines to links, unfortunately, because
quote-folding is line-based and (being regexp-based) needs
to happen after linkification.
---
lib/PublicInbox/View.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 3bb3853..3695bb2 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -221,7 +221,9 @@ sub add_filename_line {
my $LINK_RE = qr!\b((?:ftp|https?|nntp)://[@\w\+\&\?\.\%\;/#=-]+)!;
sub linkify {
- $_[0] =~ s!$LINK_RE!<a\nhref="$1"\n>$1</a>!g;
+ # no newlines added here since it'd break the splitting we do
+ # to fold quotes
+ $_[0] =~ s!$LINK_RE!<a href="$1">$1</a>!g;
}
sub add_text_body_short {
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-04 20:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 20:52 [PATCH] view: fix linkification and quote-folding conflicts Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/public-inbox.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).