From: Andreas Schwab <schwab@suse.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, DJ Delorie <dj@redhat.com>
Subject: Re: [PATCH v5] Always define __USE_TIME_BITS64 when 64 bit time_t is used
Date: Mon, 18 Mar 2024 13:07:13 +0100 [thread overview]
Message-ID: <mvmv85jkaku.fsf@suse.de> (raw)
In-Reply-To: <20240318114259.164673-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 18 Mar 2024 08:42:59 -0300")
On Mär 18 2024, Adhemerval Zanella wrote:
> diff --git a/manual/maint.texi b/manual/maint.texi
> index 89da704f45..1c441eb5f7 100644
> --- a/manual/maint.texi
> +++ b/manual/maint.texi
> @@ -491,6 +491,10 @@ derived as in the dual-time configuration case, and which expands to
> the symbol's name. For instance, the macro @code{__clock_gettime64}
> expands to @code{clock_gettime}.
>
> +When @code{__TIMESIZE == 64} is set, @theglibc{} will also define the
When @code{__TIMESIZE} is set to 64,
> +@code{__USE_TIME_BITS64}. It is used by the Linux kernel ABI to set the
the @code{__USE_TIME_BITS64} macro.
> diff --git a/sysdeps/generic/features-time64.h b/sysdeps/generic/features-time64.h
> index 4d38b8ba76..8fe811bd9e 100644
> --- a/sysdeps/generic/features-time64.h
> +++ b/sysdeps/generic/features-time64.h
> @@ -17,3 +17,7 @@
> <https://www.gnu.org/licenses/>. */
>
> /* The generic configuration only support _TIME_BITS=32. */
> +#define __USE_TIME_BITS64 0
This is supposed to be used with #ifdef, it should not be defined here.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2024-03-18 12:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 11:42 [PATCH v5] Always define __USE_TIME_BITS64 when 64 bit time_t is used Adhemerval Zanella
2024-03-18 11:58 ` Florian Weimer
2024-03-18 12:18 ` Adhemerval Zanella Netto
2024-03-18 12:07 ` Andreas Schwab [this message]
2024-03-18 12:19 ` Adhemerval Zanella Netto
-- strict thread matches above, loose matches on Subject: below --
2024-03-18 12:21 Adhemerval Zanella
2024-03-18 12:23 ` Adhemerval Zanella Netto
2024-03-18 12:37 ` Andreas Schwab
2024-03-18 12:53 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmv85jkaku.fsf@suse.de \
--to=schwab@suse.de \
--cc=adhemerval.zanella@linaro.org \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).