Re: [PATCH v5] Always define __USE_TIME_BITS64 when 64 bit time_t is used

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 18/03/24 09:07, Andreas Schwab wrote:
> On Mär 18 2024, Adhemerval Zanella wrote:
> 
>> diff --git a/manual/maint.texi b/manual/maint.texi
>> index 89da704f45..1c441eb5f7 100644
>> --- a/manual/maint.texi
>> +++ b/manual/maint.texi
>> @@ -491,6 +491,10 @@ derived as in the dual-time configuration case, and which expands to
>>  the symbol's name.  For instance, the macro @code{__clock_gettime64}
>>  expands to @code{clock_gettime}.
>>  
>> +When @code{__TIMESIZE == 64} is set, @theglibc{} will also define the
> 
> When @code{__TIMESIZE} is set to 64,
> 
>> +@code{__USE_TIME_BITS64}.  It is used by the Linux kernel ABI to set the
> 
> the @code{__USE_TIME_BITS64} macro.

Ack.

> 
>> diff --git a/sysdeps/generic/features-time64.h b/sysdeps/generic/features-time64.h
>> index 4d38b8ba76..8fe811bd9e 100644
>> --- a/sysdeps/generic/features-time64.h
>> +++ b/sysdeps/generic/features-time64.h
>> @@ -17,3 +17,7 @@
>>     <https://www.gnu.org/licenses/>.  */
>>  
>>  /* The generic configuration only support _TIME_BITS=32.  */
>> +#define __USE_TIME_BITS64       0
> 
> This is supposed to be used with #ifdef, it should not be defined here.

In fact, it now does not make much sense to add the generic features-time64.h
header (since both macros should be explicit defined).