unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Lukasz Majewski <lukma@denx.de>
Cc: Florian Weimer <fweimer@redhat.com>,
	GNU C Library <libc-alpha@sourceware.org>,
	Alistair Francis <alistair.francis@wdc.com>,
	Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v3] y2038: Replace __clock_gettime with __clock_gettime64
Date: Wed, 20 May 2020 12:29:26 +0200	[thread overview]
Message-ID: <mvmeeredhmh.fsf@suse.de> (raw)
In-Reply-To: <20200505181605.22346-1-lukma@denx.de> (Lukasz Majewski's message of "Tue, 5 May 2020 20:16:05 +0200")

On Mai 05 2020, Lukasz Majewski wrote:

> The __clock_gettime internal function is not supporting 64 bit time on
> architectures with __WORDSIZE == 32 and __TIMESIZE != 64 (like e.g. ARM 32
> bit).
>
> The __clock_gettime64 function shall be used instead in the glibc itself as
> it supports 64 bit time on those systems.
> This patch does not bring any changes to systems with __WORDSIZE == 64 as
> for them the __clock_gettime64 is aliased to __clock_gettime (in
> ./include/time.h).

Ok.

> diff --git a/nis/nis_call.c b/nis/nis_call.c
> index 92c70e97aa..da4c52bdcd 100644
> --- a/nis/nis_call.c
> +++ b/nis/nis_call.c
> @@ -575,7 +575,7 @@ static struct nis_server_cache
>    unsigned int size;
>    unsigned int server_used;
>    unsigned int current_ep;
> -  time_t expires;
> +  __time64_t expires;
>    char name[];
>  } *nis_server_cache[16];
>  static time_t nis_cold_start_mtime;

This will need to be promoted to __time64_t eventually (but not in this
patch).

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

  parent reply	other threads:[~2020-05-20 10:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 18:16 [PATCH v3] y2038: Replace __clock_gettime with __clock_gettime64 Lukasz Majewski
2020-05-19 19:51 ` Lukasz Majewski
2020-05-20 10:29 ` Andreas Schwab [this message]
2020-05-21  1:09 ` H.J. Lu via Libc-alpha
2020-05-21 10:24   ` Lukasz Majewski
2020-05-21 11:11     ` H.J. Lu via Libc-alpha
2020-05-23 20:32       ` [PATCH] Fix __clock_gettime64 for sysdeps/generic/hp-timing.h H.J. Lu via Libc-alpha
2020-05-24  9:03         ` Lukasz Majewski
2020-05-24 11:39           ` H.J. Lu via Libc-alpha
2020-05-24 15:30             ` Lukasz Majewski
2020-05-24 16:13               ` H.J. Lu via Libc-alpha
2020-05-24 23:34                 ` V2 " H.J. Lu via Libc-alpha
2020-05-25 10:40                   ` Lukasz Majewski
2020-05-25 10:57   ` [PATCH v3] y2038: Replace __clock_gettime with __clock_gettime64 Andreas Schwab
2020-05-27 12:44     ` Florian Weimer via Libc-alpha
2020-05-27 12:47       ` H.J. Lu via Libc-alpha
2020-05-27 12:50         ` Florian Weimer via Libc-alpha
2020-05-28 12:28           ` [PATCH] Fix __clock_gettime64 with _ISOMAC in sysdeps/generic/hp-timing.h H.J. Lu via Libc-alpha
2020-05-28 12:58             ` Florian Weimer via Libc-alpha
2020-05-28 13:07               ` H.J. Lu via Libc-alpha
2020-05-28 14:28                 ` Florian Weimer via Libc-alpha
2020-05-28 14:50                   ` [PATCH] Update HP_TIMING_NOW for " H.J. Lu via Libc-alpha
2020-06-05 16:26                     ` Carlos O'Donell via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmeeredhmh.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=alistair.francis@wdc.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).