From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>,
Alistair Francis <alistair.francis@wdc.com>,
"H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v3] y2038: Replace __clock_gettime with __clock_gettime64
Date: Wed, 27 May 2020 14:50:14 +0200 [thread overview]
Message-ID: <87y2pdiltl.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOoKZmyhkH4RU1R=GmzkufCHJN4BwHpk1AwZ+NbfkihMhw@mail.gmail.com> (H. J. Lu's message of "Wed, 27 May 2020 05:47:31 -0700")
* H. J. Lu:
> On Wed, May 27, 2020 at 5:44 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * Andreas Schwab:
>>
>> > I don't think it make sense for benchtests to define _ISMAC if it uses
>> > glibc internal interfaces.
>>
>> We have some internal interfaces that are available for !_ISOMAC,
>> e.g. pretty much the entire support/ directory.
>>
>> I assume this is about <hp-timing.h>? We could decide that it should be
>> in this category as well.
>
> To be precise, it is sysdeps/generic/hp-timing.h:
>
> #define HP_TIMING_NOW(var) \
> ({ \
> struct __timespec64 tv; \
> __clock_gettime64 (CLOCK_MONOTONIC, &tv); \
> (var) = (tv.tv_nsec + UINT64_C(1000000000) * tv.tv_sec); \
> })
Okay, then we could add an #ifdef _ISOMAC and use clock_gettime outside
glibc. Temporarily, until we have clock_gettime64 available outside
glibc, too.
Or would that be too awkward?
Thanks,
Florian
next prev parent reply other threads:[~2020-05-27 12:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:16 [PATCH v3] y2038: Replace __clock_gettime with __clock_gettime64 Lukasz Majewski
2020-05-19 19:51 ` Lukasz Majewski
2020-05-20 10:29 ` Andreas Schwab
2020-05-21 1:09 ` H.J. Lu via Libc-alpha
2020-05-21 10:24 ` Lukasz Majewski
2020-05-21 11:11 ` H.J. Lu via Libc-alpha
2020-05-23 20:32 ` [PATCH] Fix __clock_gettime64 for sysdeps/generic/hp-timing.h H.J. Lu via Libc-alpha
2020-05-24 9:03 ` Lukasz Majewski
2020-05-24 11:39 ` H.J. Lu via Libc-alpha
2020-05-24 15:30 ` Lukasz Majewski
2020-05-24 16:13 ` H.J. Lu via Libc-alpha
2020-05-24 23:34 ` V2 " H.J. Lu via Libc-alpha
2020-05-25 10:40 ` Lukasz Majewski
2020-05-25 10:57 ` [PATCH v3] y2038: Replace __clock_gettime with __clock_gettime64 Andreas Schwab
2020-05-27 12:44 ` Florian Weimer via Libc-alpha
2020-05-27 12:47 ` H.J. Lu via Libc-alpha
2020-05-27 12:50 ` Florian Weimer via Libc-alpha [this message]
2020-05-28 12:28 ` [PATCH] Fix __clock_gettime64 with _ISOMAC in sysdeps/generic/hp-timing.h H.J. Lu via Libc-alpha
2020-05-28 12:58 ` Florian Weimer via Libc-alpha
2020-05-28 13:07 ` H.J. Lu via Libc-alpha
2020-05-28 14:28 ` Florian Weimer via Libc-alpha
2020-05-28 14:50 ` [PATCH] Update HP_TIMING_NOW for " H.J. Lu via Libc-alpha
2020-06-05 16:26 ` Carlos O'Donell via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2pdiltl.fsf@oldenburg2.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=alistair.francis@wdc.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).