From: Andreas Schwab <schwab@suse.de>
To: Alistair Francis <alistair.francis@wdc.com>
Cc: libc-alpha@sourceware.org, alistair23@gmail.com
Subject: Re: [PATCH v2 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
Date: Wed, 25 Sep 2019 09:39:42 +0200 [thread overview]
Message-ID: <mvma7asddtt.fsf@suse.de> (raw)
In-Reply-To: <20190925003114.21546-1-alistair.francis@wdc.com> (Alistair Francis's message of "Tue, 24 Sep 2019 17:31:13 -0700")
On Sep 24 2019, Alistair Francis <alistair.francis@wdc.com> wrote:
> diff --git a/sysdeps/unix/sysv/linux/generic/bits/stat.h b/sysdeps/unix/sysv/linux/generic/bits/stat.h
> index 1565f3f8248..e580071d26c 100644
> --- a/sysdeps/unix/sysv/linux/generic/bits/stat.h
> +++ b/sysdeps/unix/sysv/linux/generic/bits/stat.h
> @@ -40,7 +40,10 @@
> /* Versions of the `xmknod' interface. */
> #define _MKNOD_VER_LINUX 0
>
> -#if defined __USE_FILE_OFFSET64
> +#if defined (__USE_FILE_OFFSET64) || defined (__INO_T_MATCHES_INO64_T)
> +# if defined (__INO_T_MATCHES_INO64_T) && !defined (__OFF_T_MATCHES_OFF64_T)
Our style is to omit the parens after defined.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2019-09-25 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 0:31 [PATCH v2 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts Alistair Francis
2019-09-25 0:31 ` [PATCH v2 2/2] Define __STATFS_MATCHES_STATFS64 Alistair Francis
2019-09-25 7:38 ` Andreas Schwab
2019-09-25 22:53 ` Alistair Francis
2019-09-25 7:39 ` Andreas Schwab [this message]
2019-09-25 22:52 ` [PATCH v2 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts Alistair Francis
-- strict thread matches above, loose matches on Subject: below --
2019-09-18 23:54 Alistair Francis
2019-09-19 20:33 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvma7asddtt.fsf@suse.de \
--to=schwab@suse.de \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).