From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1F4751F463 for ; Wed, 25 Sep 2019 07:39:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; q=dns; s=default; b=gZUBm hdWzg5n6wom4WQ4pbXTA6T7xLTkxkSTdLXaNgp0lUKxVEAPs6ZS9ATuHenDk7at4 /cQj+J/VUIWqO6dUi4dCuy6mQdwDq7knvUQfpgivl6g/A9oCYs7vdIrhO9ESUzJC pqHu4uS/WKoP21LjJeEXN9GJF2DF6yn6Ec0yX4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-type; s=default; bh=oTJFdSY28Qt bhDo5n5pY67tQzyU=; b=xresfYFKd3z5goWyyT0mFYSok6SG/qdm0/QT+c0j4NG q7ky+LDsIRKPZPdhau28O1+J91+3ZCf4VhbMUnuLGknFXyDxDKf1ju4tAJLXJZlC a1+Agsy6l3UQZnC8ljw7D6S9R/5gadticFXwG29jFjbnnJIQ3BBqy0i6Pu9b6WTw = Received: (qmail 50671 invoked by alias); 25 Sep 2019 07:39:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 50634 invoked by uid 89); 25 Sep 2019 07:39:45 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.suse.de From: Andreas Schwab To: Alistair Francis Cc: libc-alpha@sourceware.org, alistair23@gmail.com Subject: Re: [PATCH v2 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts References: <20190925003114.21546-1-alistair.francis@wdc.com> X-Yow: Is this where people are HOT and NICE and they give you TOAST for FREE?? Date: Wed, 25 Sep 2019 09:39:42 +0200 In-Reply-To: <20190925003114.21546-1-alistair.francis@wdc.com> (Alistair Francis's message of "Tue, 24 Sep 2019 17:31:13 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain On Sep 24 2019, Alistair Francis wrote: > diff --git a/sysdeps/unix/sysv/linux/generic/bits/stat.h b/sysdeps/unix/sysv/linux/generic/bits/stat.h > index 1565f3f8248..e580071d26c 100644 > --- a/sysdeps/unix/sysv/linux/generic/bits/stat.h > +++ b/sysdeps/unix/sysv/linux/generic/bits/stat.h > @@ -40,7 +40,10 @@ > /* Versions of the `xmknod' interface. */ > #define _MKNOD_VER_LINUX 0 > > -#if defined __USE_FILE_OFFSET64 > +#if defined (__USE_FILE_OFFSET64) || defined (__INO_T_MATCHES_INO64_T) > +# if defined (__INO_T_MATCHES_INO64_T) && !defined (__OFF_T_MATCHES_OFF64_T) Our style is to omit the parens after defined. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."