From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v3 08/16] elf: Enable relro for static build
Date: Thu, 2 Jan 2020 17:37:35 +0530 [thread overview]
Message-ID: <fc824b60-b972-a5e2-3972-3b0db2681d5b@gotplt.org> (raw)
In-Reply-To: <20191217214728.2886-8-adhemerval.zanella@linaro.org>
On 18/12/19 3:17 am, Adhemerval Zanella wrote:
> Changes from previous version:
>
> - The tests were removed and instead I will use the ones proposed
> by Florian's patch 'elf: Add tests for working RELRO protection'
> [1]. I also plan to send additional coverage for '.data.rel.ro'
> which trigger failures for the static case on both partial and
> full relro which is fixed by this patch once the patch is
> upstream.
>
> --
>
> The code is similar to the one at elf/dl-reloc.c, where it checks for
> the l_relro_size from the link_map (obtained from PT_GNU_RELRO header
> from program headers) and calls_dl_protected_relro.
>
> Checked on x86_64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu,
> aarch64-linux-gnu, s390x-linux-gnu, and sparc64-linux-gnu. I also
> check with --enable-static pie on x86_64-linux-gnu, i686-linux-gnu,
> and aarch64-linux-gnu which seems the only architectures where
> static PIE is actually working (as per 9d7a3741c9e, on
> arm-linux-gnueabihf, powerpc64{le}-linux-gnu, and s390x-linux-gnu
> I am seeing runtime issues not related to my patch).
>
> [1] https://sourceware.org/ml/libc-alpha/2019-10/msg00059.html
> ---
> elf/dl-support.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
OK.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
next prev parent reply other threads:[~2020-01-02 12:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 21:47 [PATCH v2 01/16] linux: Fix vDSO macros build with time64 interfaces Adhemerval Zanella
2019-12-17 21:47 ` [PATCH v2 02/16] x86: Make x32 use x86 time implementation Adhemerval Zanella
2020-01-02 12:07 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 03/16] Remove vDSO support from make-syscall.sh Adhemerval Zanella
2020-01-02 12:07 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 04/16] linux: Update x86 vDSO symbols Adhemerval Zanella
2020-01-02 12:07 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 05/16] linux: Update mips " Adhemerval Zanella
2020-01-02 12:08 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 06/16] linux: Consolidate Linux gettimeofday Adhemerval Zanella
2019-12-18 8:46 ` Andreas Schwab
2019-12-18 14:50 ` Adhemerval Zanella
2020-01-02 12:07 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 07/16] linux: Consolidate time implementation Adhemerval Zanella
2020-01-02 12:51 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH v3 08/16] elf: Enable relro for static build Adhemerval Zanella
2020-01-02 12:07 ` Siddhesh Poyarekar [this message]
2019-12-17 21:47 ` [PATCH v3 09/16] elf: Move vDSO setup to rtld (BZ#24967) Adhemerval Zanella
2020-01-02 12:55 ` Siddhesh Poyarekar
2020-01-02 13:00 ` Adhemerval Zanella
2020-01-07 16:13 ` [PATCH v3 09/16] elf: Move vDSO setup to rtld (BZ#24967) - regression found Lukasz Majewski
2020-01-07 19:40 ` Adhemerval Zanella
2019-12-17 21:47 ` [PATCH v2 10/16] linux: Add support for clock_gettime64 vDSO Adhemerval Zanella
2020-01-02 13:03 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 11/16] linux: Optimize fallback 32-bit clock_gettime Adhemerval Zanella
2019-12-18 8:53 ` Andreas Schwab
2019-12-18 14:58 ` Adhemerval Zanella
2020-01-02 13:07 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 12/16] linux: Enable vDSO clock_gettime64 for i386 Adhemerval Zanella
2020-01-02 13:08 ` Siddhesh Poyarekar
2020-01-02 13:08 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 13/16] linux: Enable vDSO clock_gettime64 for arm Adhemerval Zanella
2020-01-02 13:08 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 14/16] linux: Enable vDSO clock_gettime64 for mips Adhemerval Zanella
2019-12-18 15:33 ` Florian Weimer
2020-01-02 13:13 ` Siddhesh Poyarekar
2020-01-02 13:50 ` Adhemerval Zanella
2020-01-02 14:09 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH v2 15/16] linux: Add support for clock_getres64 vDSO Adhemerval Zanella
2020-01-02 13:15 ` Siddhesh Poyarekar
2019-12-17 21:47 ` [PATCH 16/16] linux: Optimize fallback 32-bit clock_getres Adhemerval Zanella
2019-12-18 8:56 ` Andreas Schwab
2019-12-18 14:58 ` Adhemerval Zanella
2019-12-18 15:02 ` Adhemerval Zanella
2020-01-02 13:16 ` Siddhesh Poyarekar
2020-01-02 12:07 ` [PATCH v2 01/16] linux: Fix vDSO macros build with time64 interfaces Siddhesh Poyarekar
2020-01-02 12:55 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc824b60-b972-a5e2-3972-3b0db2681d5b@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).