From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 330C31F463 for ; Thu, 2 Jan 2020 12:08:19 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=F9MOAtD1+Ld/MRb+ 6pa1AGe95XOk3FP8sYf2kDj8ERvEYMqiC+tzD1LZTRZH8puKzWY9EDTdCC1DrnZD SIz0/GhCB/nL7fjtLlzn1vbxH87JoduF/I1PQAHHUJLJLN6mud6jKoLipjDNFHF1 UyVPWhLVQG2cd1sfA7ko7Xb71hU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=cKcT0U387+8c1fpBDcmTT8 8Gk5c=; b=hXMRitGqOyWf1WzBkfyD28oAeR6jLwUrsNnfj3rhQ+Qvxxs2FUsgzs YJVgkiUxI18vnM8M1+r8pDKmM8Q9m60/OhGdJHkwcieA6w3e0GAb2nnDPtfrYAPz CkMMGi0kqxQgLSamXD/5yYcvfGVe2sSZgIXyS6CdksEvrq5+qrhO0= Received: (qmail 21575 invoked by alias); 2 Jan 2020 12:07:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 21453 invoked by uid 89); 2 Jan 2020 12:07:59 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: cadetblue.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Wide-Eyed-Cold: 66d5199045a401c3_1577966875238_992648413 X-MC-Loop-Signature: 1577966875238:3380384511 X-MC-Ingress-Time: 1577966875237 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=cKcT0U 387+8c1fpBDcmTT88Gk5c=; b=bx3uHGC6K7lnTQR2ZemVpzLrayc1K/zk0EJPBy EfD0BxqAwjLztiNvAVpRHTudqrirFUpjmpgFGAzdvut/1NejAMD71a9FlDp1kc2f tC/7iQlRiXHNJX2E4Ho2Qxi52Vfx9h5QsCPyGe+7cio8klo8FdqpslawK+66YRQI tWrg8= Subject: Re: [PATCH v3 08/16] elf: Enable relro for static build To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> <20191217214728.2886-8-adhemerval.zanella@linaro.org> X-DH-BACKEND: pdx1-sub0-mail-a59 From: Siddhesh Poyarekar Message-ID: Date: Thu, 2 Jan 2020 17:37:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20191217214728.2886-8-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdeguddgfeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufhiugguhhgvshhhucfrohihrghrvghkrghruceoshhiugguhhgvshhhsehgohhtphhlthdrohhrgheqnecuffhomhgrihhnpehrvghlrdhrohdpshhouhhrtggvfigrrhgvrdhorhhgnecukfhppeduvdefrddvhedvrddvtddvrddujedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegludelvddrudeikedruddrleejngdpihhnvghtpeduvdefrddvhedvrddvtddvrddujedvpdhrvghtuhhrnhdqphgrthhhpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqedpmhgrihhlfhhrohhmpehsihguughhvghshhesghhothhplhhtrdhorhhgpdhnrhgtphhtthhopegrughhvghmvghrvhgrlhdriigrnhgvlhhlrgeslhhinhgrrhhordhorhhgnecuvehluhhsthgvrhfuihiivgeptd On 18/12/19 3:17 am, Adhemerval Zanella wrote: > Changes from previous version: > > - The tests were removed and instead I will use the ones proposed > by Florian's patch 'elf: Add tests for working RELRO protection' > [1]. I also plan to send additional coverage for '.data.rel.ro' > which trigger failures for the static case on both partial and > full relro which is fixed by this patch once the patch is > upstream. > > -- > > The code is similar to the one at elf/dl-reloc.c, where it checks for > the l_relro_size from the link_map (obtained from PT_GNU_RELRO header > from program headers) and calls_dl_protected_relro. > > Checked on x86_64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu, > aarch64-linux-gnu, s390x-linux-gnu, and sparc64-linux-gnu. I also > check with --enable-static pie on x86_64-linux-gnu, i686-linux-gnu, > and aarch64-linux-gnu which seems the only architectures where > static PIE is actually working (as per 9d7a3741c9e, on > arm-linux-gnueabihf, powerpc64{le}-linux-gnu, and s390x-linux-gnu > I am seeing runtime issues not related to my patch). > > [1] https://sourceware.org/ml/libc-alpha/2019-10/msg00059.html > --- > elf/dl-support.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > OK. Reviewed-by: Siddhesh Poyarekar