unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] Tests for minimal signal handler functionality in MINSIGSTKSZ space.
Date: Wed, 16 Jan 2019 15:20:39 -0200	[thread overview]
Message-ID: <f65380fa-d061-ab10-beae-d2e889342afd@linaro.org> (raw)
In-Reply-To: <f2b61528-add2-6028-b9fe-0e559662193b@gotplt.org>



On 16/01/2019 01:40, Siddhesh Poyarekar wrote:
> On 16/01/19 2:45 AM, Carlos O'Donell wrote:
>> Thank you for doing this.
>>
>> OK for master with comment addition in implementation.
>>
>> You need Siddhesh to approve the extra tests.
>>
> 
> OK to add these tests to master.
> 
> Siddhesh

We need something like below for Hurd:

diff --git a/support/xsigstack.c b/support/xsigstack.c
index cebfa19..5656e84 100644
--- a/support/xsigstack.c
+++ b/support/xsigstack.c
@@ -63,6 +63,12 @@ xalloc_sigstack (size_t size)
   /* Use MAP_NORESERVE so that RAM will not be wasted on the guard
      bands; touch all the pages of the actual stack before returning,
      so we know they are allocated.  */
+#ifndef MAP_NORESERVE
+# define MAP_NORESERVE 0
+#endif
+#ifndef MAP_STACK
+# define MAP_STACK 0
+#endif
   desc->alloc_base = xmmap (0,
                             desc->alloc_size,
                             PROT_READ|PROT_WRITE,

  reply	other threads:[~2019-01-16 17:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 20:05 [PATCH] Tests for minimal signal handler functionality in MINSIGSTKSZ space Zack Weinberg
2019-01-15 21:15 ` Carlos O'Donell
2019-01-15 22:16   ` Zack Weinberg
2019-01-16  5:01     ` Carlos O'Donell
2019-01-16 14:06       ` Zack Weinberg
2019-01-16 14:16         ` Florian Weimer
2019-01-16 17:06         ` Carlos O'Donell
2019-01-16 22:47           ` Richard Henderson
2019-01-17  3:30           ` H.J. Lu
2019-01-18  2:52             ` Zack Weinberg
2019-01-18 14:53               ` H.J. Lu
2019-01-18 16:40                 ` Carlos O'Donell
2019-01-18 17:22                   ` [PATCH] Disable lazy binding on tests for minimal signal handler H.J. Lu
2019-01-18 18:08                   ` [PATCH] Tests for minimal signal handler functionality in MINSIGSTKSZ space Zack Weinberg
2019-01-18 19:49                     ` H.J. Lu
2019-01-21 18:45                       ` Carlos O'Donell
2019-01-16 22:44         ` Richard Henderson
2019-01-16  3:40   ` Siddhesh Poyarekar
2019-01-16 17:20     ` Adhemerval Zanella [this message]
2019-01-21 18:07       ` Joseph Myers
2019-01-21 18:54         ` Zack Weinberg
2019-01-16 22:41 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f65380fa-d061-ab10-beae-d2e889342afd@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).