From: Richard Henderson <rth@twiddle.net>
To: Zack Weinberg <zackw@panix.com>, Carlos O'Donell <carlos@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Siddhesh Poyarekar <siddhesh@gotplt.org>
Subject: Re: [PATCH] Tests for minimal signal handler functionality in MINSIGSTKSZ space.
Date: Thu, 17 Jan 2019 09:44:00 +1100 [thread overview]
Message-ID: <35acd0f9-7cd2-f3f1-c8d6-d91284d065a3@twiddle.net> (raw)
In-Reply-To: <CAKCAbMiaUYOLkRD36MEVJRuzbAyjC7DEYNz68ZuJdWDrq=YPRQ@mail.gmail.com>
On 1/17/19 1:06 AM, Zack Weinberg wrote:
> It also occurs to me that on some architectures MINSIGSTKSZ is less
> than a page; on those architectures, the rounding done in xsigstack.c
> means we aren't _really_ testing this stuff in MINSIGSTKSZ space.
> Since overflow is much more of a concern than underflow, what do
> people think of adjusting the code in xsigstack.c so that the area
> actually passed to sigaltstack will not be rounded and will be right
> up against the guard in the direction of overflow? This would mean
> xsigstack.c has to know which direction the stack grows, but I think
> we already have internal macros for that, so it's not a huge problem.
> I would do this as a follow-up patch if it's agreed to be a good idea.
Heh. Should have read the whole thread first.
>From my other mail, you can clearly tell that I vote yes for this. ;-)
r~
next prev parent reply other threads:[~2019-01-16 22:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 20:05 [PATCH] Tests for minimal signal handler functionality in MINSIGSTKSZ space Zack Weinberg
2019-01-15 21:15 ` Carlos O'Donell
2019-01-15 22:16 ` Zack Weinberg
2019-01-16 5:01 ` Carlos O'Donell
2019-01-16 14:06 ` Zack Weinberg
2019-01-16 14:16 ` Florian Weimer
2019-01-16 17:06 ` Carlos O'Donell
2019-01-16 22:47 ` Richard Henderson
2019-01-17 3:30 ` H.J. Lu
2019-01-18 2:52 ` Zack Weinberg
2019-01-18 14:53 ` H.J. Lu
2019-01-18 16:40 ` Carlos O'Donell
2019-01-18 17:22 ` [PATCH] Disable lazy binding on tests for minimal signal handler H.J. Lu
2019-01-18 18:08 ` [PATCH] Tests for minimal signal handler functionality in MINSIGSTKSZ space Zack Weinberg
2019-01-18 19:49 ` H.J. Lu
2019-01-21 18:45 ` Carlos O'Donell
2019-01-16 22:44 ` Richard Henderson [this message]
2019-01-16 3:40 ` Siddhesh Poyarekar
2019-01-16 17:20 ` Adhemerval Zanella
2019-01-21 18:07 ` Joseph Myers
2019-01-21 18:54 ` Zack Weinberg
2019-01-16 22:41 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35acd0f9-7cd2-f3f1-c8d6-d91284d065a3@twiddle.net \
--to=rth@twiddle.net \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).