Re: [PATCH 13/30] Linux: consolidate symlink implementation

[Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>]

On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote:
> Use symlink syscall if defined, otherwise use symlinkat.
> 
> Checked on x86_64-linux-gnu.

LGTM.

No regressions on x86_64 and i686.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>


> ---
>  sysdeps/unix/sysv/linux/{generic => }/symlink.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>  rename sysdeps/unix/sysv/linux/{generic => }/symlink.c (78%)
> 
> diff --git a/sysdeps/unix/sysv/linux/generic/symlink.c b/sysdeps/unix/sysv/linux/symlink.c
> similarity index 78%
> rename from sysdeps/unix/sysv/linux/generic/symlink.c
> rename to sysdeps/unix/sysv/linux/symlink.c
> index 9242f5825e..b336d5ec4c 100644
> --- a/sysdeps/unix/sysv/linux/generic/symlink.c
> +++ b/sysdeps/unix/sysv/linux/symlink.c
> @@ -1,4 +1,5 @@
> -/* Copyright (C) 2011-2022 Free Software Foundation, Inc.
> +/* Make a new name for a file.  Linux version.
> +   Copyright (C) 2011-2022 Free Software Foundation, Inc.
>     This file is part of the GNU C Library.
>  
>     The GNU C Library is free software; you can redistribute it and/or
> @@ -23,6 +24,10 @@
>  int
>  __symlink (const char *from, const char *to)
>  {
> -  return INLINE_SYSCALL (symlinkat, 3, from, AT_FDCWD, to);
> +#ifdef __NR_symlink
> +  return INLINE_SYSCALL_CALL (symlink, from, to);

OK.

> +#else
> +  return INLINE_SYSCALL_CALL (symlinkat, from, AT_FDCWD, to);
> +#endif
>  }
>  weak_alias (__symlink, symlink)

-- 
Cheers,
Carlos.