From: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH 27/30] Linux: make generic xstatver.h the default one
Date: Tue, 6 Dec 2022 12:33:28 -0500 [thread overview]
Message-ID: <150a459a-c5ee-c240-9488-a785acac2851@redhat.com> (raw)
In-Reply-To: <20221019221433.1082017-28-adhemerval.zanella@linaro.org>
On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote:
> And copy the current default one to required ABIs.
LGTM.
No regressions on x86_64 and i686.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
> ---
> sysdeps/unix/sysv/linux/{generic => arm}/xstatver.h | 11 +++++++----
> sysdeps/unix/sysv/linux/hppa/xstatver.h | 13 +++++++++++++
> sysdeps/unix/sysv/linux/sh/xstatver.h | 13 +++++++++++++
> sysdeps/unix/sysv/linux/xstatver.h | 11 ++++-------
> 4 files changed, 37 insertions(+), 11 deletions(-)
> rename sysdeps/unix/sysv/linux/{generic => arm}/xstatver.h (52%)
> create mode 100644 sysdeps/unix/sysv/linux/hppa/xstatver.h
> create mode 100644 sysdeps/unix/sysv/linux/sh/xstatver.h
>
> diff --git a/sysdeps/unix/sysv/linux/generic/xstatver.h b/sysdeps/unix/sysv/linux/arm/xstatver.h
> similarity index 52%
> rename from sysdeps/unix/sysv/linux/generic/xstatver.h
> rename to sysdeps/unix/sysv/linux/arm/xstatver.h
> index d8fd35beb6..8e1801b603 100644
> --- a/sysdeps/unix/sysv/linux/generic/xstatver.h
> +++ b/sysdeps/unix/sysv/linux/arm/xstatver.h
> @@ -1,10 +1,13 @@
> /* Versions of the 'struct stat' data structure used in compatibility xstat
> functions. */
> -#define _STAT_VER_KERNEL 0
> -#define _STAT_VER_LINUX 0
> -#define _STAT_VER _STAT_VER_KERNEL
> +#define _STAT_VER_LINUX_OLD 1
> +#define _STAT_VER_KERNEL 1
> +#define _STAT_VER_SVR4 2
> +#define _STAT_VER_LINUX 3
> +#define _STAT_VER _STAT_VER_LINUX
OK. Matches.
>
> /* Versions of the 'xmknod' interface used in compatibility xmknod
> functions. */
> -#define _MKNOD_VER_LINUX 0
> +#define _MKNOD_VER_LINUX 1
> +#define _MKNOD_VER_SVR4 2
> #define _MKNOD_VER _MKNOD_VER_LINUX
OK. Matches.
> diff --git a/sysdeps/unix/sysv/linux/hppa/xstatver.h b/sysdeps/unix/sysv/linux/hppa/xstatver.h
> new file mode 100644
> index 0000000000..8e1801b603
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/hppa/xstatver.h
> @@ -0,0 +1,13 @@
> +/* Versions of the 'struct stat' data structure used in compatibility xstat
> + functions. */
> +#define _STAT_VER_LINUX_OLD 1
> +#define _STAT_VER_KERNEL 1
> +#define _STAT_VER_SVR4 2
> +#define _STAT_VER_LINUX 3
> +#define _STAT_VER _STAT_VER_LINUX
OK. Matches.
> +
> +/* Versions of the 'xmknod' interface used in compatibility xmknod
> + functions. */
> +#define _MKNOD_VER_LINUX 1
> +#define _MKNOD_VER_SVR4 2
> +#define _MKNOD_VER _MKNOD_VER_LINUX
OK. Matches.
> diff --git a/sysdeps/unix/sysv/linux/sh/xstatver.h b/sysdeps/unix/sysv/linux/sh/xstatver.h
> new file mode 100644
> index 0000000000..8e1801b603
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/sh/xstatver.h
> @@ -0,0 +1,13 @@
> +/* Versions of the 'struct stat' data structure used in compatibility xstat
> + functions. */
> +#define _STAT_VER_LINUX_OLD 1
> +#define _STAT_VER_KERNEL 1
> +#define _STAT_VER_SVR4 2
> +#define _STAT_VER_LINUX 3
> +#define _STAT_VER _STAT_VER_LINUX
OK. Matches.
> +
> +/* Versions of the 'xmknod' interface used in compatibility xmknod
> + functions. */
> +#define _MKNOD_VER_LINUX 1
> +#define _MKNOD_VER_SVR4 2
> +#define _MKNOD_VER _MKNOD_VER_LINUX
OK. Matches.
> diff --git a/sysdeps/unix/sysv/linux/xstatver.h b/sysdeps/unix/sysv/linux/xstatver.h
> index 8e1801b603..d8fd35beb6 100644
> --- a/sysdeps/unix/sysv/linux/xstatver.h
> +++ b/sysdeps/unix/sysv/linux/xstatver.h
> @@ -1,13 +1,10 @@
> /* Versions of the 'struct stat' data structure used in compatibility xstat
> functions. */
> -#define _STAT_VER_LINUX_OLD 1
> -#define _STAT_VER_KERNEL 1
> -#define _STAT_VER_SVR4 2
> -#define _STAT_VER_LINUX 3
> -#define _STAT_VER _STAT_VER_LINUX
OK. Move to the targets.
> +#define _STAT_VER_KERNEL 0
> +#define _STAT_VER_LINUX 0
> +#define _STAT_VER _STAT_VER_KERNEL
>
> /* Versions of the 'xmknod' interface used in compatibility xmknod
> functions. */
> -#define _MKNOD_VER_LINUX 1
> -#define _MKNOD_VER_SVR4 2
OK. Move to the targets.
> +#define _MKNOD_VER_LINUX 0
> #define _MKNOD_VER _MKNOD_VER_LINUX
--
Cheers,
Carlos.
next prev parent reply other threads:[~2022-12-06 17:33 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 22:14 [PATCH 00/30] Remove Linux generic sysdep Adhemerval Zanella via Libc-alpha
2022-10-19 22:14 ` [PATCH 01/30] linux: Fix generic struct_stat for 64 bit time (BZ# 29657) Adhemerval Zanella via Libc-alpha
2022-10-25 17:50 ` Joseph Myers
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 02/30] linux: Consolidate dl-origin.c Adhemerval Zanella via Libc-alpha
2022-10-19 22:14 ` [PATCH 03/30] Linux: consolidate chmod implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 04/30] Linux: consolidate chown implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 05/30] Linux: consolidate dup2 implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 06/30] Lninux: consolidate epoll_create implementation Adhemerval Zanella via Libc-alpha
2022-10-21 8:57 ` Florian Weimer via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 07/30] Linux: consolidate inotify_init implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 08/30] Linux: consolidate lchown implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 09/30] Linux: consolidate link implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 10/30] Linux: consolidate mkdir implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 11/30] Linux: consolidate readlink implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 12/30] Linux: consolidate rmdir implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 13/30] Linux: consolidate symlink implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 14/30] Linux: consolidate unlink implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 15/30] Linux: consolidate sendfile implementation Adhemerval Zanella via Libc-alpha
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 16/30] Linux: Move wordsize-32 Version to default Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-12-07 0:10 ` Joseph Myers
2022-12-07 20:19 ` Adhemerval Zanella Netto via Libc-alpha
2022-10-19 22:14 ` [PATCH 17/30] Linux: consolidate ____longjmp_chk Adhemerval Zanella via Libc-alpha
2022-12-05 16:40 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 18/30] Linux: Assume and consolidate bind wire-up syscall Adhemerval Zanella via Libc-alpha
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 19/30] Linux: Assume iand consolidate socket " Adhemerval Zanella via Libc-alpha
2022-12-05 16:39 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 20/30] Linux: Assume and consolidate socketpair " Adhemerval Zanella via Libc-alpha
2022-12-06 16:15 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 21/30] Linux: Assume and consolidate listen " Adhemerval Zanella via Libc-alpha
2022-12-06 16:17 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 22/30] Linux: Assume and consolidate getsockname " Adhemerval Zanella via Libc-alpha
2022-10-20 0:01 ` Joseph Myers
2022-10-20 18:12 ` Adhemerval Zanella Netto via Libc-alpha
2022-12-06 16:18 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 23/30] Linux: Assume and consolidate getpeername " Adhemerval Zanella via Libc-alpha
2022-10-20 0:02 ` Joseph Myers
2022-12-06 16:20 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 24/30] Linux: Assume and consolidate shutdown " Adhemerval Zanella via Libc-alpha
2022-12-06 16:23 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 25/30] Linux: Remove unused generic Makefile Adhemerval Zanella via Libc-alpha
2022-12-06 17:24 ` Carlos O'Donell via Libc-alpha
2022-12-07 21:19 ` Adhemerval Zanella Netto via Libc-alpha
2022-10-19 22:14 ` [PATCH 26/30] Linux: Remove generic sysdep Adhemerval Zanella via Libc-alpha
2022-12-06 17:29 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 27/30] Linux: make generic xstatver.h the default one Adhemerval Zanella via Libc-alpha
2022-12-06 17:33 ` Carlos O'Donell via Libc-alpha [this message]
2022-10-19 22:14 ` [PATCH 28/30] Linux: Make generic fcntl.h " Adhemerval Zanella via Libc-alpha
2022-12-06 17:36 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 29/30] Linux: Consolidate typesizes.h Adhemerval Zanella via Libc-alpha
2022-12-06 17:47 ` Carlos O'Donell via Libc-alpha
2022-10-19 22:14 ` [PATCH 30/30] Linux: Remove generic Implies Adhemerval Zanella via Libc-alpha
2022-12-06 17:50 ` Carlos O'Donell via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150a459a-c5ee-c240-9488-a785acac2851@redhat.com \
--to=libc-alpha@sourceware.org \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).