unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
To: Alistair Francis <alistair23@gmail.com>,
	Joseph Myers <joseph@codesourcery.com>
Cc: nd <nd@arm.com>, GNU C Library <libc-alpha@sourceware.org>
Subject: Re: Math errors
Date: Fri, 3 Jan 2020 09:30:04 +0000	[thread overview]
Message-ID: <f04c2059-ca25-c054-5151-b9a770faa12a@arm.com> (raw)
In-Reply-To: <CAKmqyKO6tkQjTkP85z3PoX13Y+Xgd1S6zZZo0HjZQsSMW=E=9A@mail.gmail.com>

On 03/01/2020 02:18, Alistair Francis wrote:
> On Mon, Dec 30, 2019 at 2:29 PM Joseph Myers <joseph@codesourcery.com> wrote:
>>
>> On Mon, 30 Dec 2019, Joseph Myers wrote:
>>
>>> On Mon, 30 Dec 2019, Alistair Francis wrote:
>>>
>>>> Hey,
>>>>
>>>> I'm running the `make check` tests on RV32 inside QEMU and about 800
>>>> math tests are failing with errors along these lines:
>>>
>>> You need to generate libm-test-ulps for RV32 ("make regen-ulps") (also
>>> remember to create a corresponding libm-test-ulps-name file for use in
>>> generating the table in the manual).
>>
>> I should add: first try renaming the RV64 libm-test-ulps to make it
>> generic for both RV32 and RV64.  You should only need a separate file for
>> RV32 if there is a clear reason for different results between the two.
> 
> Thanks Joseph,
> 
> I moved the RV64 one to be generic and that seems to fix most of the
> math tests. I tried `make regen-ulps` after that, just to be sure, and
> it didn't generate a diff.

regen-ulps should create a math/NewUlps file.
(details are in math/README.libm-test)

> 
> There are a handful of math tests that seem to fail, but if I manually
> run the test a few times I will eventually get a pass. Any hints on
> what to do there?

flaky math test is not normal, you need to investigate.

> 
> Alistair
> 
>>
>> --
>> Joseph S. Myers
>> joseph@codesourcery.com


  reply	other threads:[~2020-01-03  9:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-30 19:52 Math errors Alistair Francis
2019-12-30 22:28 ` Joseph Myers
2019-12-30 22:29   ` Joseph Myers
2020-01-03  2:18     ` Alistair Francis
2020-01-03  9:30       ` Szabolcs Nagy [this message]
2020-01-04 18:09         ` Alistair Francis
2020-01-07  1:29       ` Jim Wilson
2020-01-07  1:32         ` Alistair Francis
2020-01-07 18:29           ` Jim Wilson
2020-01-14  2:10             ` Alistair Francis
2020-01-14  2:28               ` Jonathan Nieder
2020-01-14  4:57                 ` Alistair Francis
2020-01-14  7:28                   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f04c2059-ca25-c054-5151-b9a770faa12a@arm.com \
    --to=szabolcs.nagy@arm.com \
    --cc=alistair23@gmail.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).