From: Alistair Francis <alistair23@gmail.com>
To: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Cc: Joseph Myers <joseph@codesourcery.com>, nd <nd@arm.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: Math errors
Date: Sat, 4 Jan 2020 10:09:20 -0800 [thread overview]
Message-ID: <CAKmqyKOAUgRptiC3Cjg6ZHtTOdWrQZ7EVWr9b1yyeUiE7ehs4A@mail.gmail.com> (raw)
In-Reply-To: <f04c2059-ca25-c054-5151-b9a770faa12a@arm.com>
On Fri, Jan 3, 2020 at 1:30 AM Szabolcs Nagy <Szabolcs.Nagy@arm.com> wrote:
>
> On 03/01/2020 02:18, Alistair Francis wrote:
> > On Mon, Dec 30, 2019 at 2:29 PM Joseph Myers <joseph@codesourcery.com> wrote:
> >>
> >> On Mon, 30 Dec 2019, Joseph Myers wrote:
> >>
> >>> On Mon, 30 Dec 2019, Alistair Francis wrote:
> >>>
> >>>> Hey,
> >>>>
> >>>> I'm running the `make check` tests on RV32 inside QEMU and about 800
> >>>> math tests are failing with errors along these lines:
> >>>
> >>> You need to generate libm-test-ulps for RV32 ("make regen-ulps") (also
> >>> remember to create a corresponding libm-test-ulps-name file for use in
> >>> generating the table in the manual).
> >>
> >> I should add: first try renaming the RV64 libm-test-ulps to make it
> >> generic for both RV32 and RV64. You should only need a separate file for
> >> RV32 if there is a clear reason for different results between the two.
> >
> > Thanks Joseph,
> >
> > I moved the RV64 one to be generic and that seems to fix most of the
> > math tests. I tried `make regen-ulps` after that, just to be sure, and
> > it didn't generate a diff.
>
> regen-ulps should create a math/NewUlps file.
> (details are in math/README.libm-test)
Yep, I just meant that I diffed that to the RV64 one.
>
> >
> > There are a handful of math tests that seem to fail, but if I manually
> > run the test a few times I will eventually get a pass. Any hints on
> > what to do there?
>
> flaky math test is not normal, you need to investigate.
It turns out that there is a difference between libm-test-ulps for
RV32 and RV64. The gen-libm-test.py script was failing to run as I
don't have Python2 installed, so the file wasn't being updated. If I
manually run the script with Python3 I can generate a libm-test-ulps
file that is somewhat different to the RV64 one.
I'm running the tests now, but hopefully that fixes the failing math test cases.
Alistair
>
> >
> > Alistair
> >
> >>
> >> --
> >> Joseph S. Myers
> >> joseph@codesourcery.com
>
next prev parent reply other threads:[~2020-01-04 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 19:52 Math errors Alistair Francis
2019-12-30 22:28 ` Joseph Myers
2019-12-30 22:29 ` Joseph Myers
2020-01-03 2:18 ` Alistair Francis
2020-01-03 9:30 ` Szabolcs Nagy
2020-01-04 18:09 ` Alistair Francis [this message]
2020-01-07 1:29 ` Jim Wilson
2020-01-07 1:32 ` Alistair Francis
2020-01-07 18:29 ` Jim Wilson
2020-01-14 2:10 ` Alistair Francis
2020-01-14 2:28 ` Jonathan Nieder
2020-01-14 4:57 ` Alistair Francis
2020-01-14 7:28 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKOAUgRptiC3Cjg6ZHtTOdWrQZ7EVWr9b1yyeUiE7ehs4A@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).