Re: [PATCH v2] Add libm_alias_finite for _finite symbols

[Siddhesh Poyarekar <siddhesh@gotplt.org>]

On 21/10/19 11:15 pm, Adhemerval Zanella wrote:
> From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
> 
> Sending on behalf of Wilco.  Changes from previous version:
> 
>  - Fixed various missing compat symbols for i386, x86_64 and m68k.
> 
>  - Created libm-alias-finite.h which defines the libm_alias_finite
>    macro that wraps the logic required to define the compat finite
>    symbol.
> 
>  - Redefine declare_mgen_finite_alias_x as libm_alias_finite.
> 
>  - Adjusted for some non-existent files (powerpc exp multiarch).
> 
> --
> 
> This patch adds a new macro, libm_alias_finite, to define all _finite
> symbol.  It sets all _finite symbol as compat symbol based on its first
> version (obtained from the definition at built generated first-versions.h).
> 
> The <fn>f128_finite symbols were introduced in GLIBC 2.26 and so need
> special treatment in code that is shared between long double and float128.
> It is done by adding a list, similar to internal symbol redifinition,
> on sysdeps/ieee754/float128/float128_private.h.
> 
> Alpha also needs some tricky changes to ensure we still emit 2 compat
> symbols for sqrt(f).
> 
> Passes buildmanyglibc.
> 
> Co-authored-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>

This looks OK to me with the following changes:

1. Change SHLIB_COMPAT call to use 2_31 in libm-alias-finite.h and in
   the alpha files

2. Update year in the copyright header.

Siddhesh