From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 96BAF1F463 for ; Thu, 2 Jan 2020 07:58:39 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=QjX+I8nX+mRpl1zj xqhEhv3GXIXDiGT8Espv9neLozP2GUkniXem5jjqabW7QG3tW0D2vEvgMUbPoA8g Ag4M9sLTcLfn/9CySp6pQQrMIigtdHLqxdfJWIKXjEbp7z747jVMxuiPcqyQC/gV h8/Ko/+RUk4RW4oIVkJA5+ml52o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=Ewn/a+2CPWZUxmAKMtkcXc lDPU4=; b=jIOOrTmae8jkIqMPJH2Z+Sxp3Hu8VTd1yPPwxL/QHM1abPZXJbLtAu abSKMax+q5RtsFa0+0kIajDtLXp8I+spPR1Rhj/GLMSds0UQrnHNkMAKkhu2NLxB sRIadA93lbaWTTD9/byw+ZGmR5vR205oukJW60I2HY1KTu23K/PNQ= Received: (qmail 11752 invoked by alias); 2 Jan 2020 07:58:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11743 invoked by uid 89); 2 Jan 2020 07:58:36 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: crocodile.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Whistle-Tangy: 6f673b3c294ab0b5_1577951911867_980382552 X-MC-Loop-Signature: 1577951911867:4123313525 X-MC-Ingress-Time: 1577951911866 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=Ewn/a+ 2CPWZUxmAKMtkcXclDPU4=; b=UploPOeZUtZk0GyP9YAW1W9333JBwkvpgwkiBP kg38rqf2J5lK0C0zassBsNCRfYxnHV51VQJM3ChmSE+NqbEqe8rNr80z37mxsa8T EggzorhZG6y5fjsTT4cI+SkG7VKrKkqqT5r22vWLKpc6BNbSVzos7IfwQmKqGrSR wwAus= Subject: Re: [PATCH v2] Add libm_alias_finite for _finite symbols To: Adhemerval Zanella , libc-alpha@sourceware.org Cc: Wilco Dijkstra References: <20191021174548.25467-1-adhemerval.zanella@linaro.org> X-DH-BACKEND: pdx1-sub0-mail-a39 From: Siddhesh Poyarekar Message-ID: Date: Thu, 2 Jan 2020 13:28:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20191021174548.25467-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvdegtddguddtlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqeenucfkphepgeelrddvgeekrddvfeehrddugeegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegluddttddrleeirddugeelrdduieekngdpihhnvghtpeegledrvdegkedrvdefhedrudeggedprhgvthhurhhnqdhprghthhepufhiugguhhgvshhhucfrohihrghrvghkrghruceoshhiugguhhgvshhhsehgohhtphhlthdrohhrgheqpdhmrghilhhfrhhomhepshhiugguhhgvshhhsehgohhtphhlthdrohhrghdpnhhrtghpthhtoheprgguhhgvmhgvrhhvrghlrdiirghnvghllhgrsehlihhnrghrohdrohhrghenucevlhhushhtvghrufhiiigvpedt On 21/10/19 11:15 pm, Adhemerval Zanella wrote: > From: Wilco Dijkstra > > Sending on behalf of Wilco. Changes from previous version: > > - Fixed various missing compat symbols for i386, x86_64 and m68k. > > - Created libm-alias-finite.h which defines the libm_alias_finite > macro that wraps the logic required to define the compat finite > symbol. > > - Redefine declare_mgen_finite_alias_x as libm_alias_finite. > > - Adjusted for some non-existent files (powerpc exp multiarch). > > -- > > This patch adds a new macro, libm_alias_finite, to define all _finite > symbol. It sets all _finite symbol as compat symbol based on its first > version (obtained from the definition at built generated first-versions.h). > > The f128_finite symbols were introduced in GLIBC 2.26 and so need > special treatment in code that is shared between long double and float128. > It is done by adding a list, similar to internal symbol redifinition, > on sysdeps/ieee754/float128/float128_private.h. > > Alpha also needs some tricky changes to ensure we still emit 2 compat > symbols for sqrt(f). > > Passes buildmanyglibc. > > Co-authored-by: Adhemerval Zanella This looks OK to me with the following changes: 1. Change SHLIB_COMPAT call to use 2_31 in libm-alias-finite.h and in the alpha files 2. Update year in the copyright header. Siddhesh