From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH COMMITTED] Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247]
Date: Wed, 23 May 2018 13:53:48 -0400 [thread overview]
Message-ID: <db2b39de-be98-8141-7100-362ebf3f48bc@redhat.com> (raw)
In-Reply-To: <f9c4ae59-6f56-89e9-4fb8-7f74b1ba9567@linaro.org>
On 05/23/2018 01:51 PM, Adhemerval Zanella wrote:
>
>
> On 23/05/2018 14:38, Carlos O'Donell wrote:
>> On 05/23/2018 01:12 PM, Adhemerval Zanella wrote:
>>> On 23/05/2018 13:55, Florian Weimer wrote:
>>>> On 05/23/2018 06:44 PM, H.J. Lu wrote:
>>>>> On Fedora 28, I got
>>>>>
>>>>> FAIL: resolv/tst-resolv-ai_idn FAIL:
>>>>> resolv/tst-resolv-ai_idn-latin1
>>>>
>>>> See the NEWS file. You need libidn 2.0.5 (and later) to avoid test
>>>> failures. The mirror push for that is currently under way, and you
>>>> should be able to install the new version tomorrow.
>>>
>>> Shouldn't we in this case mark the tests as unsupported instead of
>>> failing?
>>
>> $0.02. No. It should fail to indicate you have bugs in your system libidn.
>>
>> Unsupported would be if you didn't have a libidn present at all (and the
>> test looks for this too and returns FAIL_UNSUPPORTED).
>>
>
> So in this case we should at least document this better, commit message does
> not have anything regarding it and NEWS update just states "[...] libidn2
> version 2.0.5 or later is recommended. [...]" which does not really state
> why 2.0.5 is preferred.
>
> Also, reading the newer tests does give any indication why 2.0.5 is required
> to fully compliance nor they check libidn2 version. To one involved in glibc
> developments it should be straightforward to relate possible test-suite to
> related error, but I still think that indicating that system tests libidn is
> the culprit nor glibc itself is a better error output.
That sounds good to me. I'll let Florian respond here and add more NEWS information
that people think should be present.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2018-05-23 17:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 13:29 [PATCH COMMITTED] Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247] Florian Weimer
2018-05-23 16:44 ` H.J. Lu
2018-05-23 16:55 ` Florian Weimer
2018-05-23 17:12 ` Adhemerval Zanella
2018-05-23 17:38 ` Carlos O'Donell
2018-05-23 17:51 ` Adhemerval Zanella
2018-05-23 17:53 ` Carlos O'Donell [this message]
2018-05-23 19:33 ` Florian Weimer
2018-05-23 20:34 ` Adhemerval Zanella
2018-05-23 20:35 ` Adhemerval Zanella
2019-01-21 9:10 ` Andreas Schwab
2019-01-21 9:30 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db2b39de-be98-8141-7100-362ebf3f48bc@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).