From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH COMMITTED] Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247]
Date: Mon, 21 Jan 2019 10:30:16 +0100 [thread overview]
Message-ID: <87ef96icif.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <mvmfttmcr5t.fsf@suse.de> (Andreas Schwab's message of "Mon, 21 Jan 2019 10:10:22 +0100")
* Andreas Schwab:
> On Mai 23 2018, fweimer@redhat.com (Florian Weimer) wrote:
>
>> diff --git a/inet/idna.c b/inet/idna.c
>> new file mode 100644
>> index 0000000000..c561bf2e9e
>> --- /dev/null
>> +++ b/inet/idna.c
>> @@ -0,0 +1,182 @@
>> +/* IDNA functions, forwarding to implementations in libidn2.
>> + Copyright (C) 2018 Free Software Foundation, Inc.
>> + This file is part of the GNU C Library.
>> +
>> + The GNU C Library is free software; you can redistribute it and/or
>> + modify it under the terms of the GNU Lesser General Public
>> + License as published by the Free Software Foundation; either
>> + version 2.1 of the License, or (at your option) any later version.
>> +
>> + The GNU C Library is distributed in the hope that it will be useful,
>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> + Lesser General Public License for more details.
>> +
>> + You should have received a copy of the GNU Lesser General Public
>> + License along with the GNU C Library; if not, see
>> + <http://www.gnu.org/licenses/>. */
>> +
>> +#include <allocate_once.h>
>> +#include <dlfcn.h>
>> +#include <inet/net-internal.h>
>> +#include <netdb.h>
>> +#include <stdbool.h>
>> +
>> +/* Use the soname and version to locate libidn2, to ensure a
>> + compatible ABI. */
>> +#define LIBIDN2_SONAME "libidn2.so.0"
>
> That library no longer exists.
See <https://gitlab.com/libidn/libidn2/issues/63>. The soname bump
appears unnecessary. Let's wait a few days and see how libidn2 upstream
reacts.
Thanks,
Florian
prev parent reply other threads:[~2019-01-21 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 13:29 [PATCH COMMITTED] Switch IDNA implementation to libidn2 [BZ #19728] [BZ #19729] [BZ #22247] Florian Weimer
2018-05-23 16:44 ` H.J. Lu
2018-05-23 16:55 ` Florian Weimer
2018-05-23 17:12 ` Adhemerval Zanella
2018-05-23 17:38 ` Carlos O'Donell
2018-05-23 17:51 ` Adhemerval Zanella
2018-05-23 17:53 ` Carlos O'Donell
2018-05-23 19:33 ` Florian Weimer
2018-05-23 20:34 ` Adhemerval Zanella
2018-05-23 20:35 ` Adhemerval Zanella
2019-01-21 9:10 ` Andreas Schwab
2019-01-21 9:30 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef96icif.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).