unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v2] Fix failing nss/tst-nss-files-hosts-long.
@ 2021-07-12  9:00 Stefan Liebler via Libc-alpha
  2021-07-12  9:31 ` Florian Weimer via Libc-alpha
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Liebler via Libc-alpha @ 2021-07-12  9:00 UTC (permalink / raw)
  To: libc-alpha; +Cc: fweimer, Stefan Liebler

Sometimes the test nss/tst-nss-files-hosts-long is failing as getent
fails with exit-code 2.

This happens if tst-reload1 was run just before this test:
make t=nss/tst-reload1 test
make t=nss/tst-nss-files-hosts-long test
Then the test fails as /etc/nsswitch.conf contains "hosts: test2"
and the hosts are not searched in /etc/hosts at all.

Thus this patch just requests a post cleanup after nss/tst-reload1
has run.
---
 nss/tst-reload1.root/postclean.req | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 nss/tst-reload1.root/postclean.req

diff --git a/nss/tst-reload1.root/postclean.req b/nss/tst-reload1.root/postclean.req
new file mode 100644
index 0000000000..e69de29bb2
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Fix failing nss/tst-nss-files-hosts-long.
  2021-07-12  9:00 [PATCH v2] Fix failing nss/tst-nss-files-hosts-long Stefan Liebler via Libc-alpha
@ 2021-07-12  9:31 ` Florian Weimer via Libc-alpha
  2021-07-12  9:59   ` Stefan Liebler via Libc-alpha
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer via Libc-alpha @ 2021-07-12  9:31 UTC (permalink / raw)
  To: Stefan Liebler; +Cc: libc-alpha

* Stefan Liebler:

> Sometimes the test nss/tst-nss-files-hosts-long is failing as getent
> fails with exit-code 2.
>
> This happens if tst-reload1 was run just before this test:
> make t=nss/tst-reload1 test
> make t=nss/tst-nss-files-hosts-long test
> Then the test fails as /etc/nsswitch.conf contains "hosts: test2"
> and the hosts are not searched in /etc/hosts at all.
>
> Thus this patch just requests a post cleanup after nss/tst-reload1
> has run.
> ---
>  nss/tst-reload1.root/postclean.req | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  create mode 100644 nss/tst-reload1.root/postclean.req
>
> diff --git a/nss/tst-reload1.root/postclean.req b/nss/tst-reload1.root/postclean.req
> new file mode 100644
> index 0000000000..e69de29bb2

Looks okay to me.

Thanks,
Florian


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Fix failing nss/tst-nss-files-hosts-long.
  2021-07-12  9:31 ` Florian Weimer via Libc-alpha
@ 2021-07-12  9:59   ` Stefan Liebler via Libc-alpha
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Liebler via Libc-alpha @ 2021-07-12  9:59 UTC (permalink / raw)
  To: Florian Weimer; +Cc: libc-alpha

On 12/07/2021 11:31, Florian Weimer wrote:
> * Stefan Liebler:
> 
>> Sometimes the test nss/tst-nss-files-hosts-long is failing as getent
>> fails with exit-code 2.
>>
>> This happens if tst-reload1 was run just before this test:
>> make t=nss/tst-reload1 test
>> make t=nss/tst-nss-files-hosts-long test
>> Then the test fails as /etc/nsswitch.conf contains "hosts: test2"
>> and the hosts are not searched in /etc/hosts at all.
>>
>> Thus this patch just requests a post cleanup after nss/tst-reload1
>> has run.
>> ---
>>  nss/tst-reload1.root/postclean.req | 0
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>  create mode 100644 nss/tst-reload1.root/postclean.req
>>
>> diff --git a/nss/tst-reload1.root/postclean.req b/nss/tst-reload1.root/postclean.req
>> new file mode 100644
>> index 0000000000..e69de29bb2
> 
> Looks okay to me.
> 
> Thanks,
> Florian
> 

Committed.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-12 10:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12  9:00 [PATCH v2] Fix failing nss/tst-nss-files-hosts-long Stefan Liebler via Libc-alpha
2021-07-12  9:31 ` Florian Weimer via Libc-alpha
2021-07-12  9:59   ` Stefan Liebler via Libc-alpha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).