From: Alistair Francis via Libc-alpha <libc-alpha@sourceware.org>
To: libc-alpha@sourceware.org
Cc: alistair.francis@wdc.com
Subject: [PATCH v3 14/19] RISC-V: Fix llrint and llround missing exceptions on RV32
Date: Sun, 12 Jul 2020 08:47:58 -0700 [thread overview]
Message-ID: <b2373731b97952b74a5fda99dc96d649a9d780d8.1594568655.git.alistair.francis@wdc.com> (raw)
In-Reply-To: <cover.1594568655.git.alistair.francis@wdc.com>
From: Zong Li <zongbox@gmail.com>
Similar to the fix for MIPS, ARM and S/390, RV32 is missing
correct exception on overflow from llrint and llround functions because
cast from floating-point types to long long do not result in correct
exceptions on overflow.
---
.../riscv/rv32/fix-fp-int-convert-overflow.h | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
new file mode 100644
index 0000000000..2ab1497587
--- /dev/null
+++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h
@@ -0,0 +1,38 @@
+/* Fix for conversion of floating point to integer overflow. RISC-V version.
+ Copyright (C) 2020 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <https://www.gnu.org/licenses/>. */
+
+#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H
+#define FIX_FP_INT_CONVERT_OVERFLOW_H 1
+
+/* The generic libgcc2.c conversions from floating point
+ to long long may not raise the correct exceptions on overflow (and
+ may raise spurious "inexact" exceptions even in non-overflow cases,
+ see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59412>). */
+#define FIX_FLT_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_DBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1
+
+#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0
+#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0
+
+#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0
+#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0
+
+#endif /* fix-fp-int-convert-overflow.h */
--
2.27.0
next prev parent reply other threads:[~2020-07-12 15:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 15:47 [PATCH v3 00/19] glibc port for 32-bit RISC-V (RV32) Alistair Francis via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 01/19] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Alistair Francis via Libc-alpha
2020-07-15 17:29 ` Maciej W. Rozycki via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 02/19] RISC-V: Cleanup some of the sysdep.h code Alistair Francis via Libc-alpha
2020-07-16 1:07 ` Maciej W. Rozycki via Libc-alpha
2020-08-10 15:16 ` Alistair Francis via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 03/19] RISC-V: Use 64-bit-time syscall numbers with the 32-bit port Alistair Francis via Libc-alpha
2020-07-16 1:58 ` Maciej W. Rozycki via Libc-alpha
2020-08-10 15:15 ` Alistair Francis via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 04/19] RISC-V: Add support for 32-bit vDSO calls Alistair Francis via Libc-alpha
2020-07-16 0:12 ` Maciej W. Rozycki via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 05/19] RISC-V: Support dynamic loader for the 32-bit Alistair Francis via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 06/19] sysv/linux: riscv: Fix dl-cache.h indentation Alistair Francis via Libc-alpha
2020-07-16 6:31 ` Maciej W. Rozycki via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 07/19] RISC-V: Add path of library directories for the 32-bit Alistair Francis via Libc-alpha
2020-07-16 7:03 ` Maciej W. Rozycki via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 08/19] RISC-V: Add arch-syscall.h for RV32 Alistair Francis via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 09/19] RISC-V: nptl: update default pthread-offsets.h Alistair Francis via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 10/19] RISC-V: Support the 32-bit ABI implementation Alistair Francis via Libc-alpha
2020-07-16 8:23 ` Maciej W. Rozycki via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 11/19] RISC-V: Hard float support for 32-bit Alistair Francis via Libc-alpha
2020-07-16 8:27 ` Maciej W. Rozycki via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 12/19] RISC-V: Add ABI lists Alistair Francis via Libc-alpha
2020-07-12 15:47 ` [PATCH v3 13/19] RISC-V: Add the RV32 libm-test-ulps Alistair Francis via Libc-alpha
2020-07-13 17:14 ` Maciej W. Rozycki via Libc-alpha
2020-07-13 17:32 ` Alistair Francis via Libc-alpha
2020-07-13 19:19 ` Maciej W. Rozycki via Libc-alpha
2020-07-13 19:38 ` Carlos O'Donell via Libc-alpha
2020-07-30 23:11 ` [PATCH] RISC-V: Update lp64d libm-test-ulps according to HiFive Unleashed Maciej W. Rozycki via Libc-alpha
2020-08-03 17:52 ` Carlos O'Donell via Libc-alpha
2020-08-04 12:01 ` Maciej W. Rozycki via Libc-alpha
2020-07-13 21:26 ` [PATCH v3 13/19] RISC-V: Add the RV32 libm-test-ulps Joseph Myers
2020-07-13 21:30 ` Carlos O'Donell via Libc-alpha
2020-07-13 21:59 ` Joseph Myers
2020-07-13 22:26 ` Andrew Waterman
2020-07-14 0:00 ` Maciej W. Rozycki via Libc-alpha
2020-07-14 17:24 ` Joseph Myers
2020-07-12 15:47 ` Alistair Francis via Libc-alpha [this message]
2020-07-14 22:13 ` [PATCH v3 14/19] RISC-V: Fix llrint and llround missing exceptions on RV32 Maciej W. Rozycki via Libc-alpha
2020-07-22 16:30 ` Alistair Francis via Libc-alpha
2020-07-12 15:48 ` [PATCH v3 15/19] RISC-V: Build Infastructure for 32-bit Alistair Francis via Libc-alpha
2020-07-14 23:55 ` Maciej W. Rozycki via Libc-alpha
2020-08-10 15:45 ` Alistair Francis via Libc-alpha
2020-07-12 15:48 ` [PATCH v3 16/19] riscv32: Specify the arch_minimum_kernel as 5.4 Alistair Francis via Libc-alpha
2020-07-15 0:06 ` Maciej W. Rozycki via Libc-alpha
2020-07-16 1:34 ` Maciej W. Rozycki via Libc-alpha
2020-07-12 15:48 ` [PATCH v3 17/19] RISC-V: Add rv32 path to RTLDLIST in ldd Alistair Francis via Libc-alpha
2020-07-15 0:32 ` Maciej W. Rozycki via Libc-alpha
2020-08-10 20:04 ` Alistair Francis via Libc-alpha
2020-07-12 15:48 ` [PATCH v3 18/19] Documentation for the RISC-V 32-bit port Alistair Francis via Libc-alpha
2020-07-13 17:17 ` Adhemerval Zanella via Libc-alpha
2020-07-14 13:28 ` Alistair Francis via Libc-alpha
2020-07-15 0:53 ` Maciej W. Rozycki via Libc-alpha
2020-07-22 16:33 ` Alistair Francis via Libc-alpha
2020-07-12 15:48 ` [PATCH v3 19/19] Add RISC-V 32-bit target to build-many-glibcs.py Alistair Francis via Libc-alpha
2020-07-15 1:16 ` Maciej W. Rozycki via Libc-alpha
2020-07-13 21:15 ` [PATCH v3 00/19] glibc port for 32-bit RISC-V (RV32) Joseph Myers
2020-07-14 13:18 ` Alistair Francis via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2373731b97952b74a5fda99dc96d649a9d780d8.1594568655.git.alistair.francis@wdc.com \
--to=libc-alpha@sourceware.org \
--cc=alistair.francis@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).