From: Joseph Myers <joseph@codesourcery.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>,
Andreas Schwab <schwab@suse.de>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH 1/2] y2038: Adjust struct __stat64_t64 to be usable by redirected {f}stat{at} calls
Date: Wed, 14 Oct 2020 13:09:54 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2010141308030.7380@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20201014104750.230023bc@jawa>
On Wed, 14 Oct 2020, Lukasz Majewski wrote:
> The only change, that I'm going to do is to mode __ino64_t st_ino
> member of struct __stat64_t64
> (@ sysdeps/unix/sysv/linux/struct_stat_time64.h) to the end of this
> structure (as it is in the exported struct stat{64} placed).
>
> This would allow less #ifndef __USE_TIME_BITS64 in the exported struct
> stat{64}.
I don't think any reordering is needed. I expect each header defining
struct stat / struct stat64 to do something like
#if __GLIBC_USE (TIME_BITS64)
__STAT64_T64_CONTENT
#else
/* existing struct contents */
#endif
so just one #if in each such struct definition (given that you define
__STAT64_T64_CONTENT in some installed bits/ header to avoid duplication).
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2020-10-14 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:16 [PATCH 1/2] y2038: Adjust struct __stat64_t64 to be usable by redirected {f}stat{at} calls Lukasz Majewski
2020-10-13 13:16 ` [PATCH 2/2] y2038: Remove not used __fstatat_time64 define Lukasz Majewski
2020-10-13 13:31 ` Andreas Schwab
2020-10-13 22:17 ` [PATCH 1/2] y2038: Adjust struct __stat64_t64 to be usable by redirected {f}stat{at} calls Joseph Myers
2020-10-14 8:47 ` Lukasz Majewski
2020-10-14 13:09 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010141308030.7380@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=alistair.francis@wdc.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=schwab@suse.de \
--cc=stepan@golosunov.pp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).