From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00, DATE_IN_PAST_06_12,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A048D1F4B4 for ; Wed, 14 Oct 2020 20:54:38 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78B4B394343C; Wed, 14 Oct 2020 20:54:36 +0000 (GMT) Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id D2992394343A for ; Wed, 14 Oct 2020 20:54:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D2992394343A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: aFE1lqY0ATsrZpbq6JoqQxcolsQ/FdE+GaWtagZ1e7GWcq8Vgsvi7ilSz5VQoD23jkZY7MfJmC NL7AKtjOB5TCbWbQhRYaAEHXChnUhqAV6ZL4NcsSJ01b9QDtxe7tZNYwsod/ONbxpI3isHdS3m L/ewuYXnUriuTVWSn9uSIuCkYJS3PlzzaT2EM2HLYuCR3De16MFbTX2BOo5TUzo0SPdjE5RW/b uMYx3oJsVWmJS3FM1yiCb9dV0Bx5+10ZHjcvhTjcx605D/NhL2XDuLzcNBFS75M0bweie7PG9Z ZmI= X-IronPort-AV: E=Sophos;i="5.77,376,1596528000"; d="scan'208";a="53949707" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 14 Oct 2020 12:54:25 -0800 IronPort-SDR: tLUXNZF2gYzmvy+wRWA1atomQU3BuNIb9Asv4Pl5fpCTmCX9FbnK92tKnJEtkse28edBIh2Iu9 NzcpWwVdrrpGmXKpUoPxrM/Gbd7FB5fbHVE+U3wspPtsfiH4alCp5g+ygTHZNFEE0ScmuIBLXd y5m2Fx3Oi5+uZ0OWbBp0GPIPlsaGT1Xsdk8IqUKtJw7C9SznSqh7VSQL+OYnMPOVno6K8VNPrx UoQMczinYVIm64uVmakxofwPI4K8pbRSJ6SXarW/YcgUY0XSYCbZsznoVvvnuB4kTgJuM29eEI J3k= Date: Wed, 14 Oct 2020 13:09:54 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Lukasz Majewski Subject: Re: [PATCH 1/2] y2038: Adjust struct __stat64_t64 to be usable by redirected {f}stat{at} calls In-Reply-To: <20201014104750.230023bc@jawa> Message-ID: References: <20201013131603.12557-1-lukma@denx.de> <20201014104750.230023bc@jawa> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , GNU C Library , Andreas Schwab , Stepan Golosunov , Alistair Francis Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Wed, 14 Oct 2020, Lukasz Majewski wrote: > The only change, that I'm going to do is to mode __ino64_t st_ino > member of struct __stat64_t64 > (@ sysdeps/unix/sysv/linux/struct_stat_time64.h) to the end of this > structure (as it is in the exported struct stat{64} placed). > > This would allow less #ifndef __USE_TIME_BITS64 in the exported struct > stat{64}. I don't think any reordering is needed. I expect each header defining struct stat / struct stat64 to do something like #if __GLIBC_USE (TIME_BITS64) __STAT64_T64_CONTENT #else /* existing struct contents */ #endif so just one #if in each such struct definition (given that you define __STAT64_T64_CONTENT in some installed bits/ header to avoid duplication). -- Joseph S. Myers joseph@codesourcery.com