* Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h
@ 2020-08-12 23:20 Joseph Myers
2020-08-18 23:09 ` Ping " Joseph Myers
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Joseph Myers @ 2020-08-12 23:20 UTC (permalink / raw)
To: libc-alpha
This patch adds the new STATX_MNT_ID, STATX_ATTR_MOUNT_ROOT and
STATX_ATTR_DAX macros from Linux 5.8 to glibc's bits/statx-generic.h.
(As with previous such changes, this only does anything if glibc is
being used with old kernel headers.)
A comment in the Linux kernel headers indicates that STATX_ALL is
deliberately not being changed.
Tested for x86_64.
diff --git a/io/bits/statx-generic.h b/io/bits/statx-generic.h
index 7a09e94be2..c34697e3c1 100644
--- a/io/bits/statx-generic.h
+++ b/io/bits/statx-generic.h
@@ -40,6 +40,7 @@
# define STATX_BASIC_STATS 0x07ffU
# define STATX_ALL 0x0fffU
# define STATX_BTIME 0x0800U
+# define STATX_MNT_ID 0x1000U
# define STATX__RESERVED 0x80000000U
# define STATX_ATTR_COMPRESSED 0x0004
@@ -48,7 +49,9 @@
# define STATX_ATTR_NODUMP 0x0040
# define STATX_ATTR_ENCRYPTED 0x0800
# define STATX_ATTR_AUTOMOUNT 0x1000
+# define STATX_ATTR_MOUNT_ROOT 0x2000
# define STATX_ATTR_VERITY 0x100000
+# define STATX_ATTR_DAX 0x2000
#endif /* !STATX_TYPE */
__BEGIN_DECLS
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply related [flat|nested] 5+ messages in thread* Ping Re: Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h
2020-08-12 23:20 Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h Joseph Myers
@ 2020-08-18 23:09 ` Joseph Myers
2020-08-19 7:16 ` Andreas Schwab
2020-08-20 7:24 ` Andreas Schwab
2 siblings, 0 replies; 5+ messages in thread
From: Joseph Myers @ 2020-08-18 23:09 UTC (permalink / raw)
To: libc-alpha
Ping. This patch
<https://sourceware.org/pipermail/libc-alpha/2020-August/117010.html> is
pending review.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h
2020-08-12 23:20 Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h Joseph Myers
2020-08-18 23:09 ` Ping " Joseph Myers
@ 2020-08-19 7:16 ` Andreas Schwab
2020-08-20 7:24 ` Andreas Schwab
2 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2020-08-19 7:16 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha
On Aug 12 2020, Joseph Myers wrote:
> This patch adds the new STATX_MNT_ID, STATX_ATTR_MOUNT_ROOT and
> STATX_ATTR_DAX macros from Linux 5.8 to glibc's bits/statx-generic.h.
> (As with previous such changes, this only does anything if glibc is
> being used with old kernel headers.)
>
> A comment in the Linux kernel headers indicates that STATX_ALL is
> deliberately not being changed.
Ok.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h
2020-08-12 23:20 Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h Joseph Myers
2020-08-18 23:09 ` Ping " Joseph Myers
2020-08-19 7:16 ` Andreas Schwab
@ 2020-08-20 7:24 ` Andreas Schwab
2020-08-20 7:59 ` Florian Weimer
2 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2020-08-20 7:24 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha
Do we also need to update struct statx?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h
2020-08-20 7:24 ` Andreas Schwab
@ 2020-08-20 7:59 ` Florian Weimer
0 siblings, 0 replies; 5+ messages in thread
From: Florian Weimer @ 2020-08-20 7:59 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-alpha, Joseph Myers
* Andreas Schwab:
> Do we also need to update struct statx?
The intent was not to update it. The definitions are only active if
the installed kernel headers are too old. We probably should not
change the version conditional because that would make the member
types more unpredictable (the __u64 vs uint64_t issue).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-20 7:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 23:20 Add new STATX_* constants from Linux 5.8 to bits/statx-generic.h Joseph Myers
2020-08-18 23:09 ` Ping " Joseph Myers
2020-08-19 7:16 ` Andreas Schwab
2020-08-20 7:24 ` Andreas Schwab
2020-08-20 7:59 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).