From: Joseph Myers <joseph@codesourcery.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Alistair Francis <alistair23@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Zack Weinberg <zackw@panix.com>, Arnd Bergmann <arnd@arndb.de>,
GNU C Library <libc-alpha@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>
Subject: Re: [PATCH v8 3/3] y2038: linux: Provide __clock_settime64 implementation
Date: Wed, 18 Sep 2019 21:43:10 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1909182129140.28094@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20190918211603.8444-4-lukma@denx.de>
On Wed, 18 Sep 2019, Lukasz Majewski wrote:
> Tests:
> - The code has been tested with x86_64/x86 (native compilation):
> make PARALLELMFLAGS="-j8" && make xcheck PARALLELMFLAGS="-j8"
>
> - Run specific tests on ARM/x86 32bit systems (qemu):
> https://github.com/lmajewski/meta-y2038
> and run tests:
> https://github.com/lmajewski/y2038-tests/commits/master
> on kernels with and without 64 bit time support.
Could you give more details of the configurations (including kernel
headers version, --enable-kernel version, kernel version used at runtime)
for which you have built glibc and run the full glibc testsuite? I
suspect this code is pretty close to being ready to go in - but such
patches have plenty of scope for mistakes (such as were in earlier RV32
patch versions) such as typos, transposed parameters, etc., that are hard
for humans to spot reliably and easy for compilers and testsuites to spot,
so it's important to know that sufficient automated tests have been run to
catch any such mistakes.
I gave a list in
<https://sourceware.org/ml/libc-alpha/2019-08/msg00234.html> of five
configurations I think are relevant to cover the different cases in
patches such as this ("new" = 5.1 or later; Florian's changes to provide
syscall tables in glibc would allow "#ifdef __NR_clock_settime64" to be
removed and eliminate case (b)):
(a) one that has always had 64-bit time, e.g. x86_64;
(b) one with 32-bit time and old kernel headers (any kernel version at
runtime);
(c) one with 32-bit time and new kernel headers, old kernel at runtime;
(d) one with 32-bit time and new kernel headers, new kernel at runtime but
no --enable-kernel;
(e) one with 32-bit time and new kernel at runtime and new
--enable-kernel.
If some of these are problematic to test, you can ask for help testing
them. For *this particular* patch you might not need to test both (c) and
(d), because they are identical as far as compilation is concerned and the
testsuite doesn't really cover execution of clock_settime anyway. But
it's in the nature of the Y2038 changes - involving lots of conditional
code - that it's necessary to test in several different configurations to
cover the conditionals adequately.
(For avoidance of doubt, it is *not* necessary to run build-many-glibcs.py
for this patch, and nor would running build-many-glibcs.py be sufficient
since it doesn't do execution testing or cover the kernel headers version
and --enable-kernel variants.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-09-18 21:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 21:16 [PATCH v8 0/3] y2038: Linux: Introduce __clock_settime64 function Lukasz Majewski
2019-09-18 21:16 ` [PATCH v8 1/3] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-09-19 20:14 ` Joseph Myers
2019-09-23 21:21 ` Lukasz Majewski
2019-09-25 0:47 ` Joseph Myers
2019-09-25 7:45 ` Lukasz Majewski
2019-09-25 12:51 ` Florian Weimer
2019-09-25 13:34 ` Lukasz Majewski
2019-09-25 13:40 ` Florian Weimer
2019-09-25 14:38 ` Lukasz Majewski
2019-09-25 16:28 ` Joseph Myers
2019-09-25 20:03 ` Lukasz Majewski
2019-09-25 12:43 ` Florian Weimer
2019-09-25 13:06 ` Lukasz Majewski
2019-09-25 13:07 ` Florian Weimer
2019-09-18 21:16 ` [PATCH v8 2/3] y2038: Provide conversion helpers for " Lukasz Majewski
2019-09-19 20:17 ` Joseph Myers
2019-09-19 21:21 ` Lukasz Majewski
2019-09-19 21:28 ` Joseph Myers
2019-09-19 22:03 ` Lukasz Majewski
2019-09-19 22:17 ` Joseph Myers
2019-09-19 22:22 ` Lukasz Majewski
2019-09-18 21:16 ` [PATCH v8 3/3] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-09-18 21:43 ` Joseph Myers [this message]
2019-09-18 22:33 ` Lukasz Majewski
2019-09-19 22:00 ` Lukasz Majewski
2019-09-18 23:32 ` [PATCH v8 0/3] y2038: Linux: Introduce __clock_settime64 function Alistair Francis
2019-09-19 7:51 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909182129140.28094@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).