From: Lukasz Majewski <lukma@denx.de>
To: Joseph Myers <joseph@codesourcery.com>,
Florian Weimer <fw@deneb.enyo.de>
Cc: Alistair Francis <alistair23@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Zack Weinberg <zackw@panix.com>, Arnd Bergmann <arnd@arndb.de>,
GNU C Library <libc-alpha@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
Stepan Golosunov <stepan@golosunov.pp.ru>
Subject: Re: [PATCH v8 1/3] y2038: Introduce internal for glibc struct __timespec64
Date: Wed, 25 Sep 2019 22:03:15 +0200 [thread overview]
Message-ID: <20190925220315.64e6cdae@jawa> (raw)
In-Reply-To: <alpine.DEB.2.21.1909251625570.21121@digraph.polyomino.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
Hi Joseph, Florian,
> On Wed, 25 Sep 2019, Lukasz Majewski wrote:
>
> > Let's wait for Joseph's opinion if we shall replace named padding
> > struct members with unnamed bitfields (and drop potential support
> > for fixing issues, which would require explicit clearing of padding
> > before passing data to the kernel).
>
> I'm not particularly concerned with whether this patch uses named
> padding, unnamed bit-field or 64-bit tv_nsec in the internal struct
> __timespec64. (I don't think a named bit-field would make sense
> there, however.) If we use an unnamed bit-field now we can readily
> change it later to have a name if we decide to support clearing
> padding for compat syscalls for kernels 5.1.0 to 5.1.4.
>
Shall I assume that the consensus is to use unnamed bit-field to pad
the tv_nsec?
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-25 20:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 21:16 [PATCH v8 0/3] y2038: Linux: Introduce __clock_settime64 function Lukasz Majewski
2019-09-18 21:16 ` [PATCH v8 1/3] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-09-19 20:14 ` Joseph Myers
2019-09-23 21:21 ` Lukasz Majewski
2019-09-25 0:47 ` Joseph Myers
2019-09-25 7:45 ` Lukasz Majewski
2019-09-25 12:51 ` Florian Weimer
2019-09-25 13:34 ` Lukasz Majewski
2019-09-25 13:40 ` Florian Weimer
2019-09-25 14:38 ` Lukasz Majewski
2019-09-25 16:28 ` Joseph Myers
2019-09-25 20:03 ` Lukasz Majewski [this message]
2019-09-25 12:43 ` Florian Weimer
2019-09-25 13:06 ` Lukasz Majewski
2019-09-25 13:07 ` Florian Weimer
2019-09-18 21:16 ` [PATCH v8 2/3] y2038: Provide conversion helpers for " Lukasz Majewski
2019-09-19 20:17 ` Joseph Myers
2019-09-19 21:21 ` Lukasz Majewski
2019-09-19 21:28 ` Joseph Myers
2019-09-19 22:03 ` Lukasz Majewski
2019-09-19 22:17 ` Joseph Myers
2019-09-19 22:22 ` Lukasz Majewski
2019-09-18 21:16 ` [PATCH v8 3/3] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-09-18 21:43 ` Joseph Myers
2019-09-18 22:33 ` Lukasz Majewski
2019-09-19 22:00 ` Lukasz Majewski
2019-09-18 23:32 ` [PATCH v8 0/3] y2038: Linux: Introduce __clock_settime64 function Alistair Francis
2019-09-19 7:51 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925220315.64e6cdae@jawa \
--to=lukma@denx.de \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=stepan@golosunov.pp.ru \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).