From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <codonell@redhat.com>
Cc: libc-alpha <libc-alpha@sourceware.org>,
Mark Wielaard <mjw@redhat.com>, Nick Clifton <nickc@redhat.com>,
Jeff Law <law@redhat.com>, "Frank Ch. Eigler" <fche@redhat.com>,
Pedro Alves <palves@redhat.com>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: glibc git commit hooks update.
Date: Thu, 16 May 2019 19:35:38 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1905161933150.26505@digraph.polyomino.org.uk> (raw)
In-Reply-To: <ed822689-7171-b1de-ed46-bec81c9f266e@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On Wed, 17 Apr 2019, Carlos O'Donell wrote:
> > One problem with the old hooks was that they did not generate a
> > Content-Type header, which was unhelpful when the mails also weren't pure
> > ASCII. I see the new ones are generating 'Content-Type: text/plain;
> > charset="us-ascii"'. Will they also be smart about specifying an
> > appropriate character set (so UTF-8 if the commit message / author name /
> > diff contents are valid UTF-8 but not ASCII, for example)?
>
> All of this is handled by python's email package and some handling
> on the hooks part. If everything is ASCII then we don't do any special
> encoding and just send ASCII. Otherwise we choose UTF-8 first and if
> that fails a decode test then we fallback to ISO-8859-1.
This does not seem to be working as intended. See e.g.
https://sourceware.org/ml/glibc-cvs/2019-q2/msg00147.html (UTF-8 bytes
marked as us-ascii, so ’ appears as â??, for example).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-05-16 19:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 19:29 glibc git commit hooks update Carlos O'Donell
2019-04-15 19:55 ` Zack Weinberg
2019-04-15 20:16 ` DJ Delorie
2019-04-15 20:22 ` Florian Weimer
2019-04-15 20:24 ` DJ Delorie
2019-04-15 20:28 ` Florian Weimer
2019-04-15 20:33 ` DJ Delorie
2019-04-15 20:39 ` Florian Weimer
2019-04-15 21:47 ` Yann Droneaud
2019-04-16 7:06 ` Florian Weimer
2019-04-15 21:08 ` Adhemerval Zanella
2019-04-17 22:21 ` Joseph Myers
2019-04-18 0:20 ` Carlos O'Donell
2019-04-18 12:38 ` Joseph Myers
2019-04-18 12:46 ` Florian Weimer
2019-04-18 14:45 ` Joseph Myers
2019-05-16 10:13 ` Florian Weimer
2019-05-16 19:35 ` Joseph Myers [this message]
2019-05-16 20:03 ` Carlos O'Donell
2019-05-16 20:27 ` Joseph Myers
2019-05-16 20:51 ` Carlos O'Donell
2019-05-16 21:05 ` Joseph Myers
2019-05-16 20:57 ` Florian Weimer
2019-05-16 21:06 ` Carlos O'Donell
2019-05-23 10:05 ` Andreas Schwab
2019-05-25 1:15 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1905161933150.26505@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=codonell@redhat.com \
--cc=fche@redhat.com \
--cc=fweimer@redhat.com \
--cc=law@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=mjw@redhat.com \
--cc=nickc@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).