From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 152CC1F461 for ; Thu, 16 May 2019 19:35:48 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=nXGR+ jg7ZeVzjzqI+0tPNKxQ+8jdtQD7WJvl4U9qXXlbQxA9X+WAF/OC2TpT7hEpZc37D vdDNFXpMVwgGpGaBmP1kIB6ZHISpjExNRhbvIRuJPE92fXl5v3afN4/gbOpzoT2v ASWFzJrdiUK+ahUY3jDJlwP/PL2p9c8WpfDEv8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=8PMKudV8td8 8YYpoBdotTzzVwMs=; b=BITYpAClXU0XNORBnwYjgUMAg+T96rxAWmgYQ6JvdpZ cEmhOKpdbYEtXAbfMvxFrokWr/UDOs+ZWGVeWcoN0zzbCuUCJ1p0M46e/1SLF8vG AwRvWdAUlQoabyPwerdA/vMWcHHIpkvbYHi8rRXwJ471lzUtrVfJSk9UcBX8iTGI = Received: (qmail 114543 invoked by alias); 16 May 2019 19:35:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 114527 invoked by uid 89); 16 May 2019 19:35:45 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Thu, 16 May 2019 19:35:38 +0000 From: Joseph Myers To: Carlos O'Donell CC: libc-alpha , Mark Wielaard , Nick Clifton , Jeff Law , "Frank Ch. Eigler" , Pedro Alves , Florian Weimer Subject: Re: glibc git commit hooks update. In-Reply-To: Message-ID: References: <56d46408-8314-aa01-91da-f8e32f2f56d1@redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-313685469-1558035338=:26505" ---1152306461-313685469-1558035338=:26505 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT On Wed, 17 Apr 2019, Carlos O'Donell wrote: > > One problem with the old hooks was that they did not generate a > > Content-Type header, which was unhelpful when the mails also weren't pure > > ASCII. I see the new ones are generating 'Content-Type: text/plain; > > charset="us-ascii"'. Will they also be smart about specifying an > > appropriate character set (so UTF-8 if the commit message / author name / > > diff contents are valid UTF-8 but not ASCII, for example)? > > All of this is handled by python's email package and some handling > on the hooks part. If everything is ASCII then we don't do any special > encoding and just send ASCII. Otherwise we choose UTF-8 first and if > that fails a decode test then we fallback to ISO-8859-1. This does not seem to be working as intended. See e.g. https://sourceware.org/ml/glibc-cvs/2019-q2/msg00147.html (UTF-8 bytes marked as us-ascii, so ’ appears as â??, for example). -- Joseph S. Myers joseph@codesourcery.com ---1152306461-313685469-1558035338=:26505--