unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Stepan Golosunov <stepan@golosunov.pp.ru>
Cc: Lukasz Majewski <lukma@denx.de>, <libc-alpha@sourceware.org>,
	Arnd Bergmann <arnd@arndb.de>, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH v2 2/7] y2038: Introduce __ASSUME_64BIT_TIME define
Date: Thu, 9 May 2019 16:12:13 +0000	[thread overview]
Message-ID: <alpine.DEB.2.21.1905091606460.2272@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20190508194829.z5kwaqwu57hvadaw@sghpc.golosunov.pp.ru>

On Wed, 8 May 2019, Stepan Golosunov wrote:

> You need to handle the following 4 cases:

And, to be clear:

These cases are ones to think about when writing a patch in this area.

They are not cases that should be enumerated in comments in the code for 
any particular function, because they are completely standard for how 
these syscalls are handled across all such functions and comments in a 
function should be about things specific to that particular function - we 
don't want repetitive comments that all describe the same generic things.  
Most of this is also generic to *any* case in glibc where we have optional 
support for using a new syscall, with fallback code when the syscall can't 
be assumed to be supported.

If those general rules about optional support for new syscalls are to be 
documented anywhere in glibc, I think maint.texi would be the right place 
for such documentation.

If some function has a good reason for *not* following the generic pattern 
you described, *that* would be a case for having a comment in the function 
explaining why it's not implemented in the normal way.

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2019-05-09 16:12 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 22:08 [PATCH 0/6] y2038: Linux: Provide __clock_* functions supporting 64 bit time Lukasz Majewski
2019-04-14 22:08 ` [PATCH 1/6] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-04-14 22:08 ` [PATCH 2/6] y2038: Provide conversion helpers for " Lukasz Majewski
2019-04-14 22:08 ` [PATCH 3/6] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-04-17 22:08   ` Joseph Myers
2019-04-18  6:46     ` Lukasz Majewski
2019-04-20  0:20   ` Stepan Golosunov
2019-04-20 11:21     ` Lukasz Majewski
2019-04-22  9:07       ` Stepan Golosunov
2019-04-22 21:45         ` Arnd Bergmann
2019-04-23 15:45           ` Lukasz Majewski
2019-04-14 22:08 ` [PATCH 4/6] y2038: linux: Provide __clock_getres64 implementation Lukasz Majewski
2019-04-14 22:08 ` [PATCH 5/6] y2038: linux: Provide __clock_gettime64 implementation Lukasz Majewski
2019-04-14 22:08 ` [PATCH 6/6] y2038: linux: Provide __clock_nanosleep64 implementation Lukasz Majewski
2019-04-17 22:11   ` Joseph Myers
2019-04-18  5:54     ` Lukasz Majewski
2019-04-29 10:46 ` [PATCH v2 0/7] y2038: Linux: Provide __clock_* functions supporting 64 bit time Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 1/7] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 2/7] y2038: Introduce __ASSUME_64BIT_TIME define Lukasz Majewski
2019-04-29 21:50     ` Joseph Myers
2019-04-30  9:05       ` Lukasz Majewski
2019-04-30 21:47         ` Stepan Golosunov
2019-05-02  8:51           ` Lukasz Majewski
2019-05-02 11:54             ` Stepan Golosunov
2019-05-02 13:55               ` Lukasz Majewski
2019-05-06 13:38                 ` Lukasz Majewski
2019-05-06 14:26                   ` Lukasz Majewski
2019-05-06 19:36                     ` Stepan Golosunov
2019-05-06 21:14                       ` Lukasz Majewski
2019-05-07 20:03                         ` Stepan Golosunov
2019-05-07 20:44                           ` Joseph Myers
2019-05-08  7:51                           ` Lukasz Majewski
2019-05-08 19:48                             ` Stepan Golosunov
2019-05-09 16:12                               ` Joseph Myers [this message]
2019-05-16  4:00                               ` Arnd Bergmann
2019-05-16 19:54                                 ` Stepan Golosunov
2019-05-16 19:59                                 ` Joseph Myers
2019-05-17  7:23                                   ` Florian Weimer
2019-05-17  8:34                                     ` Arnd Bergmann
2019-05-07 15:43                       ` Joseph Myers
2019-05-02 15:04         ` Joseph Myers
2019-05-05 14:10           ` Stepan Golosunov
2019-05-05 20:46             ` Lukasz Majewski
2019-05-06 14:56           ` Lukasz Majewski
2019-05-07 15:35             ` Joseph Myers
2019-05-08 10:18               ` Lukasz Majewski
2019-05-09 15:46                 ` Joseph Myers
2019-05-15 15:39                   ` Lukasz Majewski
2019-05-16  3:57                     ` Arnd Bergmann
2019-05-16  6:58                       ` Lukasz Majewski
2019-05-31 11:37                 ` Stepan Golosunov
2019-06-05 16:35                   ` Lukasz Majewski
2019-06-06  6:50                     ` Stepan Golosunov
2019-04-29 10:46   ` [PATCH v2 3/7] y2038: Provide conversion helpers for struct __timespec64 Lukasz Majewski
2019-05-02 11:56     ` Stepan Golosunov
2019-05-02 14:17       ` Lukasz Majewski
2019-05-02 15:59         ` Joseph Myers
2019-05-02 16:19           ` Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 4/7] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 5/7] y2038: linux: Provide __clock_getres64 implementation Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 6/7] y2038: linux: Provide __clock_gettime64 implementation Lukasz Majewski
2019-04-29 10:46   ` [PATCH v2 7/7] y2038: linux: Provide __clock_nanosleep64 implementation Lukasz Majewski
2019-05-07 13:18 ` [PATCH v3 0/5] y2038: Linux: Provide __clock_settime function supporting 64 bit time Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 1/5] y2038: Introduce __ASSUME_TIME64_SYSCALLS define Lukasz Majewski
2019-05-07 16:04     ` Joseph Myers
2019-05-07 13:18   ` [PATCH v3 2/5] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-05-07 13:30     ` Andreas Schwab
2019-05-07 14:07       ` Lukasz Majewski
2019-05-07 14:13         ` Andreas Schwab
2019-05-08  8:32           ` Lukasz Majewski
2019-05-08  8:38             ` Andreas Schwab
2019-05-08  9:10               ` Lukasz Majewski
2019-05-08  9:12                 ` Andreas Schwab
2019-05-08  9:37                   ` Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 3/5] y2038: Provide conversion helpers for " Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 4/5] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-05-07 16:40     ` Joseph Myers
2019-05-07 13:18   ` [PATCH v3 5/5] y2038: Support for Y2038 safe time on 32 bit systems Lukasz Majewski
2019-05-07 16:37     ` Joseph Myers
2019-05-08 10:27       ` Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 0/5] y2038: Linux: Provide __clock_settime function supporting 64 bit time Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 1/5] y2038: Introduce __ASSUME_TIME64_SYSCALLS define Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 2/5] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 3/5] y2038: Provide conversion helpers for " Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 4/5] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-05-07 13:18   ` [PATCH v3 5/5] y2038: Support for Y2038 safe time on 32 bit systems Lukasz Majewski
2019-05-07 13:34     ` Andreas Schwab
2019-05-08 15:56 ` [PATCH] y2038: Introduce __ASSUME_TIME64_SYSCALLS define Lukasz Majewski
2019-05-09 15:58   ` Joseph Myers
2019-05-09 16:18     ` Stepan Golosunov
2019-05-15 14:27 ` [PATCH v5] " Lukasz Majewski
2019-05-21 15:15   ` Lukasz Majewski
2019-05-23  7:34   ` Stepan Golosunov
2019-05-23  9:35     ` Lukasz Majewski
2019-05-25 16:19       ` Lukasz Majewski
2019-05-25 19:45       ` Stepan Golosunov
2019-05-26 12:39         ` Lukasz Majewski
2019-05-28 16:00           ` Lukasz Majewski
2019-05-28 19:53           ` Joseph Myers
2019-05-28 22:46             ` Lukasz Majewski
2019-05-28 22:50               ` Joseph Myers
2019-05-28 19:47         ` Joseph Myers
2019-05-28 22:09           ` Lukasz Majewski
2019-05-28 22:43             ` Joseph Myers
2019-05-23 21:17     ` Joseph Myers
2019-05-20 10:27 ` [PATCH v4 0/3] y2038: Linux: Provide __clock_settime64 function supporting 64 bit time Lukasz Majewski
2019-05-20 10:27   ` [PATCH v4 1/3] y2038: Introduce internal for glibc struct __timespec64 Lukasz Majewski
2019-05-20 10:27   ` [PATCH v4 2/3] y2038: Provide conversion helpers for " Lukasz Majewski
2019-05-20 10:27   ` [PATCH v4 3/3] y2038: linux: Provide __clock_settime64 implementation Lukasz Majewski
2019-05-23  7:08     ` Stepan Golosunov
2019-05-23  9:28       ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1905091606460.2272@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=arnd@arndb.de \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    --cc=stepan@golosunov.pp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).