unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: naohirot--- via Libc-alpha <libc-alpha@sourceware.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: RE: [PATCH v3 2/5] AArch64: Improve A64FX memset
Date: Tue, 3 Aug 2021 03:08:01 +0000	[thread overview]
Message-ID: <TYAPR01MB602522EA93AEC92084E47323DFF09@TYAPR01MB6025.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TYAPR01MB60257096F2A5BDFD5D7DE5D4DFEB9@TYAPR01MB6025.jpnprd01.prod.outlook.com>

Hi Wilco,

I found my typo in the original code comment.
Would you fix it with the following?
> > -#define ZF_DIST                (CACHE_LINE_SIZE * 21)  // Zerofill distance

> From: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>
> Sent: Monday, August 2, 2021 10:29 PM
> > diff --git a/sysdeps/aarch64/multiarch/memset_a64fx.S b/sysdeps/aarch64/multiarch/memset_a64fx.S
> > index f7fcc7b323e1553f50a2e005b8ccef344a08127d..608e0e2e2ff5259178e2fdadf1eea8816194d879 100644
> > --- a/sysdeps/aarch64/multiarch/memset_a64fx.S
> > +++ b/sysdeps/aarch64/multiarch/memset_a64fx.S
> > @@ -30,10 +30,8 @@
> >  #define L2_SIZE         (8*1024*1024)	// L2 8MB - 1MB

Wrong: // L2 8MB - 1MB
Right: // L2 8MB

> >  #define CACHE_LINE_SIZE	256
> >  #define PF_DIST_L1	(CACHE_LINE_SIZE * 16)	// Prefetch distance L1
> > -#define rest		x8
> > +#define rest		x2
> >  #define vector_length	x9
> > -#define vl_remainder	x10	// vector_length remainder
> > -#define cl_remainder	x11	// CACHE_LINE_SIZE remainder
> >

Thanks.
Naohiro

  reply	other threads:[~2021-08-03  3:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 16:00 [PATCH v3 2/5] AArch64: Improve A64FX memset Wilco Dijkstra via Libc-alpha
2021-08-02 13:29 ` naohirot--- via Libc-alpha
2021-08-03  3:08   ` naohirot--- via Libc-alpha [this message]
2021-08-03  5:03   ` naohirot--- via Libc-alpha
2021-08-09 16:16     ` Wilco Dijkstra via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB602522EA93AEC92084E47323DFF09@TYAPR01MB6025.jpnprd01.prod.outlook.com \
    --to=libc-alpha@sourceware.org \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=naohirot@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).