From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 1/2] i686: Don't include multiarch memove in libc.a
Date: Mon, 30 Aug 2021 05:57:00 -0700 [thread overview]
Message-ID: <CAMe9rOrG6TB++kXEQ7GhGsU6BDwkgCyZ_yfExQa80t=AdnanFQ@mail.gmail.com> (raw)
In-Reply-To: <20210809141659.2075052-2-hjl.tools@gmail.com>
On Mon, Aug 9, 2021 at 7:17 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On i686, there is no multiarch memove in libc.a, don't include multiarch
> memove in ifunc-impl-list.c in libc.a.
> ---
> sysdeps/i386/i686/multiarch/ifunc-impl-list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/i386/i686/multiarch/ifunc-impl-list.c b/sysdeps/i386/i686/multiarch/ifunc-impl-list.c
> index 4e3cc56fa3..d3365cdc9d 100644
> --- a/sysdeps/i386/i686/multiarch/ifunc-impl-list.c
> +++ b/sysdeps/i386/i686/multiarch/ifunc-impl-list.c
> @@ -84,7 +84,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> __memmove_chk_sse2_unaligned)
> IFUNC_IMPL_ADD (array, i, __memmove_chk, 1,
> __memmove_chk_ia32))
> -#endif
>
> /* Support sysdeps/i386/i686/multiarch/memmove.S. */
> IFUNC_IMPL (i, name, memmove,
> @@ -95,6 +94,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> IFUNC_IMPL_ADD (array, i, memmove, CPU_FEATURE_USABLE (SSE2),
> __memmove_sse2_unaligned)
> IFUNC_IMPL_ADD (array, i, memmove, 1, __memmove_ia32))
> +#endif
>
> /* Support sysdeps/i386/i686/multiarch/memrchr.S. */
> IFUNC_IMPL (i, name, memrchr,
> --
> 2.31.1
>
I am checking in this as an obvious fix.
--
H.J.
next prev parent reply other threads:[~2021-08-30 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 14:16 [PATCH v2 0/2] benchtests: Building benchmarks as static executables H.J. Lu via Libc-alpha
2021-08-09 14:16 ` [PATCH v2 1/2] i686: Don't include multiarch memove in libc.a H.J. Lu via Libc-alpha
2021-08-30 12:57 ` H.J. Lu via Libc-alpha [this message]
2021-08-09 14:16 ` [PATCH v2 2/2] benchtests: Building benchmarks as static executables H.J. Lu via Libc-alpha
2021-10-04 14:32 ` H.J. Lu via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrG6TB++kXEQ7GhGsU6BDwkgCyZ_yfExQa80t=AdnanFQ@mail.gmail.com' \
--to=libc-alpha@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).