From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B1A441F8C6 for ; Mon, 30 Aug 2021 12:57:59 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9A0E385783D for ; Mon, 30 Aug 2021 12:57:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9A0E385783D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630328277; bh=E/+xDss2O2XsuD2bmSfNX1AlEnSG1kSsoPk9Q1NKTLM=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=RY2x21TTvSWNu0nTicCB4BxWk74TEbzXer6hiy1G3CgWzcderijTKYWXS2yfaHHOw vIrtMCaKFckDwRgFCbwtWrBNWTV1F78/cLvE4H7zn8BQycgGegbiVLh+pEnS2nEV9y DHSfK8rm0EdM2bdyLkAKb7OXuH6x78VRx+wTG7t0= Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 4AC733858D35 for ; Mon, 30 Aug 2021 12:57:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AC733858D35 Received: by mail-pg1-x52e.google.com with SMTP id g184so13359441pgc.6 for ; Mon, 30 Aug 2021 05:57:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E/+xDss2O2XsuD2bmSfNX1AlEnSG1kSsoPk9Q1NKTLM=; b=hhjlWI3hfqK54xdnAGXmN4HyLjf0CqiScaJ1gPZf4N14UEv0RW+NDC78lpg+in5MUa 8TrNyiPOxt83eGSkLyCsQtg1R9li43TanlgymF9Tm+t70M3/2mE22gkoRr90QaigFy7i X4cDWsyd7P6wq9DdPEZYt5Z6TfZOfPu4F3wFPnOtK854WUSAiI1JpieUJJEZHyTNS/59 +Fp7ZQPeXetGAkSMpj1aifwyQF+vGpr7oarTza0UW62g7R8g4OhCD2lvQNREbs/0v8C3 wlfcr6WuIWdKf0k0D9sp6gzyFokkgkBg59nEvhMsXV9xcoQDDKuh/TP+8MjzbZLoLQvo DzoA== X-Gm-Message-State: AOAM533BULHpuLAW1ZwlhHNjSMDvhQTVxcsnob1votGlPJpp16qyyOV3 v40hi/sIHHYSn67gch5eCUCHuZxQQ56oGn2gna9WzCSy X-Google-Smtp-Source: ABdhPJwjwCVt9XqXd4t35PkJGxAQHMrIvB7UpYaXwlM41jyS9uqXru23ekW1KL31daQf5zf+bi+xH/6OeOxeXvc43mU= X-Received: by 2002:a63:504a:: with SMTP id q10mr14625752pgl.37.1630328256029; Mon, 30 Aug 2021 05:57:36 -0700 (PDT) MIME-Version: 1.0 References: <20210809141659.2075052-1-hjl.tools@gmail.com> <20210809141659.2075052-2-hjl.tools@gmail.com> In-Reply-To: <20210809141659.2075052-2-hjl.tools@gmail.com> Date: Mon, 30 Aug 2021 05:57:00 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] i686: Don't include multiarch memove in libc.a To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Mon, Aug 9, 2021 at 7:17 AM H.J. Lu wrote: > > On i686, there is no multiarch memove in libc.a, don't include multiarch > memove in ifunc-impl-list.c in libc.a. > --- > sysdeps/i386/i686/multiarch/ifunc-impl-list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/i386/i686/multiarch/ifunc-impl-list.c b/sysdeps/i386/i686/multiarch/ifunc-impl-list.c > index 4e3cc56fa3..d3365cdc9d 100644 > --- a/sysdeps/i386/i686/multiarch/ifunc-impl-list.c > +++ b/sysdeps/i386/i686/multiarch/ifunc-impl-list.c > @@ -84,7 +84,6 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > __memmove_chk_sse2_unaligned) > IFUNC_IMPL_ADD (array, i, __memmove_chk, 1, > __memmove_chk_ia32)) > -#endif > > /* Support sysdeps/i386/i686/multiarch/memmove.S. */ > IFUNC_IMPL (i, name, memmove, > @@ -95,6 +94,7 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, > IFUNC_IMPL_ADD (array, i, memmove, CPU_FEATURE_USABLE (SSE2), > __memmove_sse2_unaligned) > IFUNC_IMPL_ADD (array, i, memmove, 1, __memmove_ia32)) > +#endif > > /* Support sysdeps/i386/i686/multiarch/memrchr.S. */ > IFUNC_IMPL (i, name, memrchr, > -- > 2.31.1 > I am checking in this as an obvious fix. -- H.J.