From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 3/4] i386: Add _CET_ENDBR to assembly files without ENTRY
Date: Tue, 7 Jan 2020 15:38:49 -0800 [thread overview]
Message-ID: <CAMe9rOqzSVS3tL=_xp8AiOFXbMj5HyYvAL8Xn00k8NiBqPU-6A@mail.gmail.com> (raw)
In-Reply-To: <52b189ea-26a7-172b-f749-0b44fa44c21f@linaro.org>
On Tue, Jan 7, 2020 at 2:05 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 10/12/2019 17:47, H.J. Lu wrote:
> > diff --git a/sysdeps/unix/sysv/linux/i386/_exit.S b/sysdeps/unix/sysv/linux/i386/_exit.S
> > index d59c127501..a21d5f69b3 100644
> > --- a/sysdeps/unix/sysv/linux/i386/_exit.S
> > +++ b/sysdeps/unix/sysv/linux/i386/_exit.S
> > @@ -21,6 +21,7 @@
> > .type _exit,@function
> > .global _exit
> > _exit:
> > + _CET_ENDBR
> > movl 4(%esp), %ebx
> >
> > /* Try the new syscall first. */
> >
>
> Do we still need this for i386? I think the generic implementation
> should suffice since __NR_exit_group is always support and
> i386 does define ABORT_INSTRUCTION.
_exit.S can re removed.
--
H.J.
next prev parent reply other threads:[~2020-01-07 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 20:47 [PATCH 0/4] i386: Finish CET support H.J. Lu
2019-12-10 20:47 ` [PATCH 1/4] i386: Don't unnecessarily save and restore EAX, ECX and EDX [BZ# 25262] H.J. Lu
2019-12-10 20:47 ` [PATCH 2/4] i386/sub_n.S: Add a missing _CET_ENDBR to indirect jump target H.J. Lu
2019-12-10 20:47 ` [PATCH 3/4] i386: Add _CET_ENDBR to assembly files without ENTRY H.J. Lu
2020-01-07 22:05 ` Adhemerval Zanella
2020-01-07 23:38 ` H.J. Lu [this message]
2019-12-10 20:47 ` [PATCH 4/4] i386: Enable CET support in ucontext functions H.J. Lu
2019-12-12 12:46 ` [PATCH 0/4] i386: Finish CET support Florian Weimer
2019-12-12 15:57 ` H.J. Lu
2020-01-07 20:43 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqzSVS3tL=_xp8AiOFXbMj5HyYvAL8Xn00k8NiBqPU-6A@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).