From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D33141F463 for ; Tue, 7 Jan 2020 23:39:30 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=Bsrx zQe3FVn3teSAKgUbT0B7NbRozJL6JMhgojQtgysQyPSRxKJc6lwPI5B3VH/PXZll QhHndXdlDkmLaDVnWgpFRkqV+K1pGKqvchv2o6lZpW+DUkBrqLt6p6bodIr5C1aq RrO0748LRBT1VvY7wjagb1UaWicpoaJRphNqBk4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=Ta/1m1NVaP AwEwbpczAgO+8zfQ8=; b=DgQiW2Zel97JkYQhtFeM6jjSRMp+nEvZ3TS3eB1yk1 GvfcKs3vgF7gUTKZCLyGTq6Vq6EQt7GPNWWOlKuLb3szSACo2KYZasfcjfkyOMNd N95t08MJSbuvuFPaxTDwsq0eqU8bXodjtlrZb/itYb3PosujYSzVsEgq/1tCxX4E c= Received: (qmail 62524 invoked by alias); 7 Jan 2020 23:39:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 62501 invoked by uid 89); 7 Jan 2020 23:39:28 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-ot1-f66.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DYJ9qTKKhoNkVT86YiSDzF+o4/T+YxONdWUkkcGUw88=; b=cT0QTRn1BUORksd6/YsYaRAEmFbx3l3Ius9m7MdH4f3d3wdLy8Pm/uuV/XWJi4jpB+ mxoLLbPlD3XVUlhFsEGocVbKN6VfYtXorgNNh1D53US6/DV+TO3Kp2dNIfCbIbyAURDD sLJJIErK/eL+Ybk893pvv0y9EuXHgg+nK6bDErXa9KH7kIMw5qf58lUaU/LHVNqHhql1 JSn54Rfuqunwy2NJcBI8ujDTjHfb+xBaM+I+yCZU8wVoZDWuagUCTgHlQgVEqcrdHRGr UcKDhfxpvQssciJpkfWnjllKBRlceZ4vTSVwm9t1J+fQMC+CALaHUb/UHyNYSZyefjW8 j2oA== MIME-Version: 1.0 References: <20191210204710.4832-1-hjl.tools@gmail.com> <20191210204710.4832-4-hjl.tools@gmail.com> <52b189ea-26a7-172b-f749-0b44fa44c21f@linaro.org> In-Reply-To: <52b189ea-26a7-172b-f749-0b44fa44c21f@linaro.org> From: "H.J. Lu" Date: Tue, 7 Jan 2020 15:38:49 -0800 Message-ID: Subject: Re: [PATCH 3/4] i386: Add _CET_ENDBR to assembly files without ENTRY To: Adhemerval Zanella Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" On Tue, Jan 7, 2020 at 2:05 PM Adhemerval Zanella wrote: > > > > On 10/12/2019 17:47, H.J. Lu wrote: > > diff --git a/sysdeps/unix/sysv/linux/i386/_exit.S b/sysdeps/unix/sysv/linux/i386/_exit.S > > index d59c127501..a21d5f69b3 100644 > > --- a/sysdeps/unix/sysv/linux/i386/_exit.S > > +++ b/sysdeps/unix/sysv/linux/i386/_exit.S > > @@ -21,6 +21,7 @@ > > .type _exit,@function > > .global _exit > > _exit: > > + _CET_ENDBR > > movl 4(%esp), %ebx > > > > /* Try the new syscall first. */ > > > > Do we still need this for i386? I think the generic implementation > should suffice since __NR_exit_group is always support and > i386 does define ABORT_INSTRUCTION. _exit.S can re removed. -- H.J.