From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [RFC PATCH glibc 1/8] Introduce <elf_machine_sym_no_match.h>
Date: Mon, 23 Mar 2020 07:51:04 -0700 [thread overview]
Message-ID: <CAMe9rOqxqbyFp2h0Vj=_Zde0DQxb6aMNXC0ZDzyfsa3yR_pa4w@mail.gmail.com> (raw)
In-Reply-To: <20200323131607.15185-2-mathieu.desnoyers@efficios.com>
On Mon, Mar 23, 2020 at 6:18 AM Mathieu Desnoyers via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> From: Florian Weimer <fweimer@redhat.com>
>
> MIPS needs to ignore certain existing symbols during symbol lookup.
> The old scheme uses the ELF_MACHINE_SYM_NO_MATCH macro, with an
> inline function, within its own header, with a sysdeps override for
> MIPS. This allows re-use of the function from another file (without
> having to include <dl-machine.h> or providing the default definition
> for ELF_MACHINE_SYM_NO_MATCH).
>
> Built with build-many-glibcs.py, with manual verification that
> sysdeps/mips/elf_machine_sym_no_match.h is picked up on MIPS. Tested
> on aarch64-linux-gnu, i686-linux-gnu, powerpc64-linux-gnu,
> s390x-linux-gnu, x86_64-linux-gnu.
>
> * elf/elf_machine_sym_no_match.h: New file.
> * elf/dl-lookip.c (ELF_MACHINE_SYM_NO_MATCH): Do not define.
> * elf/dl-lookup.c (check_match) Call elf_machine_sym_no_match
> instead of ELF_MACHINE_SYM_NO_MATCH.
> * sysdeps/mips/dl-machine.h (ELF_MACHINE_SYM_NO_MATCH): Remove
> definition.
> * sysdeps/mips/elf_machine_sym_no_match.h: New file. Extracted
> from sysdeps/mips/dl-machine.h.
Why not sysdeps/generic/elf_machine_sym_no_match.h? It matches
sysdeps/mips/elf_machine_sym_no_match.h better.
--
H.J.
next prev parent reply other threads:[~2020-03-23 14:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 13:15 [RFC PATCH glibc 0/8] Restartable Sequences enablement Mathieu Desnoyers via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 1/8] Introduce <elf_machine_sym_no_match.h> Mathieu Desnoyers via Libc-alpha
2020-03-23 14:51 ` H.J. Lu via Libc-alpha [this message]
2020-03-23 17:04 ` Mathieu Desnoyers via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 2/8] Implement __libc_early_init Mathieu Desnoyers via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 3/8] nptl: Start new threads with all signals blocked [BZ #25098] Mathieu Desnoyers via Libc-alpha
2020-03-23 15:31 ` Christian Brauner
2020-03-23 17:02 ` Mathieu Desnoyers via Libc-alpha
2020-03-23 17:05 ` Christian Brauner
2020-04-22 16:38 ` Carlos O'Donell via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 4/8] glibc: Perform rseq(2) registration at C startup and thread creation (v16) Mathieu Desnoyers via Libc-alpha
2020-03-23 22:01 ` Joseph Myers
2020-03-24 13:08 ` Mathieu Desnoyers via Libc-alpha
2020-03-24 18:58 ` Joseph Myers
2020-03-24 19:44 ` Mathieu Desnoyers via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 5/8] glibc: sched_getcpu(): use rseq cpu_id TLS on Linux (v7) Mathieu Desnoyers via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 6/8] support record failure: allow use from constructor Mathieu Desnoyers via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 7/8] support: implement xpthread key create/delete (v4) Mathieu Desnoyers via Libc-alpha
2020-03-23 13:16 ` [RFC PATCH glibc 8/8] rseq registration tests (v9) Mathieu Desnoyers via Libc-alpha
-- strict thread matches above, loose matches on Subject: below --
2020-03-19 14:41 [RFC PATCH glibc 0/8] Restartable Sequences enablement Mathieu Desnoyers via Libc-alpha
2020-03-19 14:41 ` [RFC PATCH glibc 1/8] Introduce <elf_machine_sym_no_match.h> Mathieu Desnoyers via Libc-alpha
2020-01-08 14:58 [RFC PATCH glibc 0/8] Restartable Sequences enablement Mathieu Desnoyers
2020-01-08 14:58 ` [RFC PATCH glibc 1/8] Introduce <elf_machine_sym_no_match.h> Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOqxqbyFp2h0Vj=_Zde0DQxb6aMNXC0ZDzyfsa3yR_pa4w@mail.gmail.com' \
--to=libc-alpha@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).