From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7F1C31F45D for ; Mon, 23 Mar 2020 14:51:45 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 51245385B833; Mon, 23 Mar 2020 14:51:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51245385B833 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1584975104; bh=yu0Bxl4RHJfHgvMOtiU2n6aabZamxPGSSnVreDSrvUA=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QkwGy+QqlFQjE4B2fcxkb9HSf8/3N8tDUxf+BzdXcJDwuzReu9tijmtN7Biogo3ck 2NDINeLNiN2GYgoKKK/rfg6ry556l3TH1fhbO8eYmB4BjqeBZ5+3LvJ35tYq06rV3m sUsBotCA2wqa3d/v9HFICmYAxN83MMivJmwMSPOs= Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by sourceware.org (Postfix) with ESMTPS id CBE4C385B831 for ; Mon, 23 Mar 2020 14:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CBE4C385B831 Received: by mail-ot1-x343.google.com with SMTP id a6so13549769otb.10 for ; Mon, 23 Mar 2020 07:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yu0Bxl4RHJfHgvMOtiU2n6aabZamxPGSSnVreDSrvUA=; b=r9twUEJBSx1+XRD5yB9JBNpVQj96Iu+VnxV12rxK9vX1YOdyVQiqQ1bKymAlCL05UZ yc9p1TTvmLtjn/YLMUli7ToAdlAyevG4Kq5djg1IElsmP47ucLeOr6fN/OqPgCfh0cfJ M0Elgt0utBYBM0hGH4rfJI1JUusEp+xx4Tsj2QWK0MjFfRrCczeXZLob6HqPh0GpB0fX M7xmKibFe9kDpd6wLcEu9WDoEG5o2k2W3RsQyZ9vHGmJuSENtnaTAMk/oBSQRmDn0QrH f9eBHzS4Sx171X4aAmKymTAXEHtimnl2NxbRdziNo35KKFh6uCVcJ5zqyRoLKrm0yKk3 ncsw== X-Gm-Message-State: ANhLgQ0Rz9XIiWjwckqObnbm7wIMwxXK5bh+8m0YPy0mVGXkVLBzECSg 8UruAWo5vZKUnk1rS9rxQ5ioeghklcIPs4t87pc= X-Google-Smtp-Source: ADFU+vuzo3kHfHvjBiXKsSjAq5IoO0+T3yW+n8UcIE8/7m28Od/oi/2Ea3Y885c8s/V+00f0bcK5WXxK83s+OHpuSsc= X-Received: by 2002:a05:6830:1e38:: with SMTP id t24mr2001114otr.125.1584975100219; Mon, 23 Mar 2020 07:51:40 -0700 (PDT) MIME-Version: 1.0 References: <20200323131607.15185-1-mathieu.desnoyers@efficios.com> <20200323131607.15185-2-mathieu.desnoyers@efficios.com> In-Reply-To: <20200323131607.15185-2-mathieu.desnoyers@efficios.com> Date: Mon, 23 Mar 2020 07:51:04 -0700 Message-ID: Subject: Re: [RFC PATCH glibc 1/8] Introduce To: Mathieu Desnoyers Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: GNU C Library , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Mon, Mar 23, 2020 at 6:18 AM Mathieu Desnoyers via Libc-alpha wrote: > > From: Florian Weimer > > MIPS needs to ignore certain existing symbols during symbol lookup. > The old scheme uses the ELF_MACHINE_SYM_NO_MATCH macro, with an > inline function, within its own header, with a sysdeps override for > MIPS. This allows re-use of the function from another file (without > having to include or providing the default definition > for ELF_MACHINE_SYM_NO_MATCH). > > Built with build-many-glibcs.py, with manual verification that > sysdeps/mips/elf_machine_sym_no_match.h is picked up on MIPS. Tested > on aarch64-linux-gnu, i686-linux-gnu, powerpc64-linux-gnu, > s390x-linux-gnu, x86_64-linux-gnu. > > * elf/elf_machine_sym_no_match.h: New file. > * elf/dl-lookip.c (ELF_MACHINE_SYM_NO_MATCH): Do not define. > * elf/dl-lookup.c (check_match) Call elf_machine_sym_no_match > instead of ELF_MACHINE_SYM_NO_MATCH. > * sysdeps/mips/dl-machine.h (ELF_MACHINE_SYM_NO_MATCH): Remove > definition. > * sysdeps/mips/elf_machine_sym_no_match.h: New file. Extracted > from sysdeps/mips/dl-machine.h. Why not sysdeps/generic/elf_machine_sym_no_match.h? It matches sysdeps/mips/elf_machine_sym_no_match.h better. -- H.J.