From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: Rolf Eike Beer <eb@emlix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/2] rtld: fix typo in comment
Date: Tue, 22 Sep 2020 05:23:40 -0700 [thread overview]
Message-ID: <CAMe9rOq7M6=FMddON+PU75oYgqwWiY6EZCe=jRjZZmuiYNuhTA@mail.gmail.com> (raw)
In-Reply-To: <20200922121300.3503-1-eb@emlix.com>
On Tue, Sep 22, 2020 at 5:13 AM Rolf Eike Beer <eb@emlix.com> wrote:
>
> ---
> elf/rtld.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/rtld.c b/elf/rtld.c
> index 5b882163fa..99d130cd1c 100644
> --- a/elf/rtld.c
> +++ b/elf/rtld.c
> @@ -352,7 +352,7 @@ struct rtld_global _rtld_global =
> };
> /* If we would use strong_alias here the compiler would see a
> non-hidden definition. This would undo the effect of the previous
> - declaration. So spell out was strong_alias does plus add the
> + declaration. So spell out what strong_alias does plus add the
> visibility attribute. */
> extern struct rtld_global _rtld_local
> __attribute__ ((alias ("_rtld_global"), visibility ("hidden")));
> --
> 2.28.0
>
LGTM.
Thanks.
--
H.J.
next prev parent reply other threads:[~2020-09-22 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 12:12 [PATCH 1/2] rtld: fix typo in comment Rolf Eike Beer
2020-09-22 12:13 ` [PATCH 2/2] rtld: turn "Already zero" assumptions into asserts Rolf Eike Beer
2020-09-22 12:28 ` H.J. Lu via Libc-alpha
2020-09-22 12:38 ` Rolf Eike Beer
2020-09-22 12:23 ` H.J. Lu via Libc-alpha [this message]
2020-10-12 7:08 ` [PATCH 1/2] rtld: fix typo in comment Rolf Eike Beer
2020-10-13 12:52 ` H.J. Lu via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOq7M6=FMddON+PU75oYgqwWiY6EZCe=jRjZZmuiYNuhTA@mail.gmail.com' \
--to=libc-alpha@sourceware.org \
--cc=eb@emlix.com \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).