From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D16F31F4B4 for ; Tue, 22 Sep 2020 12:24:20 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD3A83987803; Tue, 22 Sep 2020 12:24:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD3A83987803 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1600777459; bh=mW1rwBlDKbeaBpW5FE8g3rOyI7zNEwTIMfktq2ke+eY=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZwZfupNCv9N/FnQI2Xzq+rJRCxXfa40ibTA1v0HMF+sM20OMs9eJahslbyo0bkalh +7O4UHjlfUObG7oW1aA3sjzFje8v/nBicX94pJ363e6wHIK5xbGRIxStV5Q76daol2 92Ad7xNunt6y5a1UKIIjTjMgHGKFyOooWi1nJ3WY= Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by sourceware.org (Postfix) with ESMTPS id D591D3870898 for ; Tue, 22 Sep 2020 12:24:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D591D3870898 Received: by mail-io1-xd41.google.com with SMTP id m17so19313229ioo.1 for ; Tue, 22 Sep 2020 05:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mW1rwBlDKbeaBpW5FE8g3rOyI7zNEwTIMfktq2ke+eY=; b=D1ovVax0bruxlqiAlrTJtLObvDaMetqUV5TGgDUriDbjHtKtwDgtwDG+mp5E/+VCsE xIg/MibbCR92K5w9wo3PgXSQUb6ZurR/HtwH+UB0wHE4qaF7E+Oy8MFMa/1injWJy6Nq X06GkidLTU4Pf1nD405u/QNT2xKdGWQ4TX+P9HIyzVmmTJsyhNbOoDwes0FxfekRHVqC lwNbBPtBamtYJcEybTpaZinfsDMfaGLGsGkXlXW03KU/OxmwWdtAQ2C2DN2D6vvhdKfo vrbi6+iTfZYKnfHxN04jBK+QmszCMnriQFhBnE23nfm+4fg2ISWrBbGBHIA5ZrzOs6Xn CzRA== X-Gm-Message-State: AOAM533ruIGc47u9iCsYQr5W/Hy0aWT2MIzE80wnUR+qZ3Slbm+c5qKn iW0oxwWxKceV7PzAvtbCgh1QTf2XwTEUJ4UFCsPdvcPs X-Google-Smtp-Source: ABdhPJyLxbR4nSYwelJSHLp1lTnES21jgnXRBmTg2WBrySvPhZko5FXKeVgXXwuPbxtVgnKyiby6kRm6kfSmsDcSi1M= X-Received: by 2002:a05:6602:6c9:: with SMTP id n9mr3075725iox.91.1600777456286; Tue, 22 Sep 2020 05:24:16 -0700 (PDT) MIME-Version: 1.0 References: <20200922121300.3503-1-eb@emlix.com> In-Reply-To: <20200922121300.3503-1-eb@emlix.com> Date: Tue, 22 Sep 2020 05:23:40 -0700 Message-ID: Subject: Re: [PATCH 1/2] rtld: fix typo in comment To: Rolf Eike Beer Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: GNU C Library Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Tue, Sep 22, 2020 at 5:13 AM Rolf Eike Beer wrote: > > --- > elf/rtld.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/elf/rtld.c b/elf/rtld.c > index 5b882163fa..99d130cd1c 100644 > --- a/elf/rtld.c > +++ b/elf/rtld.c > @@ -352,7 +352,7 @@ struct rtld_global _rtld_global = > }; > /* If we would use strong_alias here the compiler would see a > non-hidden definition. This would undo the effect of the previous > - declaration. So spell out was strong_alias does plus add the > + declaration. So spell out what strong_alias does plus add the > visibility attribute. */ > extern struct rtld_global _rtld_local > __attribute__ ((alias ("_rtld_global"), visibility ("hidden"))); > -- > 2.28.0 > LGTM. Thanks. -- H.J.