From: "H.J. Lu" <hjl.tools@gmail.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, Szabolcs Nagy <szabolcs.nagy@arm.com>,
Arjun Shankar <arjun@redhat.com>
Subject: Re: [PATCH v2 1/3] Ignore undefined symbols for -mtls-dialect=gnu2
Date: Tue, 12 Mar 2024 09:34:29 -0700 [thread overview]
Message-ID: <CAMe9rOppeqQ2SRi2Rhq_7UvBfDnw5c6XwDTUQfMGW-GQG46Kjw@mail.gmail.com> (raw)
In-Reply-To: <20240312162120.1360522-2-adhemerval.zanella@linaro.org>
On Tue, Mar 12, 2024 at 9:21 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
> So it does not fail for arm config that defaults to -mtp=soft (which
> issues a call to __aeabi_read_tp).
> ---
> configure | 2 +-
> configure.ac | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 59ff1e415d..117b48a421 100755
> --- a/configure
> +++ b/configure
> @@ -7020,7 +7020,7 @@ void foo (void)
> }
> EOF
> if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles
> - conftest.c -o conftest 1>&5'
> + -shared conftest.c -o conftest 1>&5'
> { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> (eval $ac_try) 2>&5
> ac_status=$?
> diff --git a/configure.ac b/configure.ac
> index 65799e5685..19b88a47a5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1297,7 +1297,7 @@ void foo (void)
> }
> EOF
> if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles
> - conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD])
> + -shared conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD])
> then
> libc_cv_mtls_dialect_gnu2=yes
> else
> --
> 2.34.1
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
next prev parent reply other threads:[~2024-03-12 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 16:21 [PATCH v2 0/3] Extending TLS testing and fixing TLS gnu2 for ARM Adhemerval Zanella
2024-03-12 16:21 ` [PATCH v2 1/3] Ignore undefined symbols for -mtls-dialect=gnu2 Adhemerval Zanella
2024-03-12 16:34 ` H.J. Lu [this message]
2024-03-12 16:21 ` [PATCH v2 2/3] arm: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (BZ 31372) Adhemerval Zanella
2024-03-12 16:35 ` H.J. Lu
2024-03-12 16:21 ` [PATCH v2 3/3] elf: Enable TLS descriptor tests on aarch64 Adhemerval Zanella
2024-03-12 16:38 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOppeqQ2SRi2Rhq_7UvBfDnw5c6XwDTUQfMGW-GQG46Kjw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=arjun@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).