From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
Arjun Shankar <arjun@redhat.com>
Subject: [PATCH v2 0/3] Extending TLS testing and fixing TLS gnu2 for ARM
Date: Tue, 12 Mar 2024 13:21:17 -0300 [thread overview]
Message-ID: <20240312162120.1360522-1-adhemerval.zanella@linaro.org> (raw)
A recent x86 fix for TLS descriptors [1] uncovered an ARM issue on
_dl_tlsdesc_dynamic where it fails to save/restore all possible
register.
And checking if aarch64 is also affected, I noted that the TLS
descriptor tests are only enabled iff -mtls-dialect= accepts 'gnu2'.
Since aarch64 uses a different naming for the TLS abi
(traditional/desc), some tests are not enabled. The last patch fixes
it by parametrizing the TLS descriptor dialect name.
[1] https://sourceware.org/pipermail/libc-alpha/2024-February/154995.html
Changes from v2
- Use -shared instead of -unresolved-symbols=ignore-all on configure
check.
- Extend tst-gnu2-tls2.h test for both HWCAP_ARM_VFP and
HWCAP_ARM_VFPD32.
- Use -mtls-dialect=desc for aarch64.
Adhemerval Zanella (3):
Ignore undefined symbols for -mtls-dialect=gnu2
arm: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (BZ
31372)
elf: Enable TLS descriptor tests on aarch64
config.h.in | 3 +
configure | 25 ++++---
configure.ac | 17 +++--
elf/Makefile | 30 ++++----
elf/tst-gnu2-tls2.h | 4 ++
elf/tst-gnu2-tls2mod0.c | 3 +-
elf/tst-gnu2-tls2mod1.c | 3 +-
elf/tst-gnu2-tls2mod2.c | 3 +-
sysdeps/aarch64/preconfigure | 1 +
sysdeps/arm/Makefile | 8 +--
sysdeps/arm/configure | 32 +++++++++
sysdeps/arm/configure.ac | 15 ++++
sysdeps/arm/dl-tlsdesc.S | 70 ++++++++++++++++---
sysdeps/arm/tst-gnu2-tls2.h | 128 +++++++++++++++++++++++++++++++++++
14 files changed, 292 insertions(+), 50 deletions(-)
create mode 100644 sysdeps/arm/tst-gnu2-tls2.h
--
2.34.1
next reply other threads:[~2024-03-12 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 16:21 Adhemerval Zanella [this message]
2024-03-12 16:21 ` [PATCH v2 1/3] Ignore undefined symbols for -mtls-dialect=gnu2 Adhemerval Zanella
2024-03-12 16:34 ` H.J. Lu
2024-03-12 16:21 ` [PATCH v2 2/3] arm: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (BZ 31372) Adhemerval Zanella
2024-03-12 16:35 ` H.J. Lu
2024-03-12 16:21 ` [PATCH v2 3/3] elf: Enable TLS descriptor tests on aarch64 Adhemerval Zanella
2024-03-12 16:38 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312162120.1360522-1-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=arjun@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).