unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: New math test failures on Fedora/33
Date: Mon, 11 Jan 2021 10:37:27 -0800	[thread overview]
Message-ID: <CAMe9rOpZq1f_4XK89a+wX9Gr3sk5qGxZg4VO5y2BfVg+5E++EQ@mail.gmail.com> (raw)
In-Reply-To: <4b0af99b-8353-7201-ec79-aae1b8eada70@linaro.org>

On Mon, Jan 11, 2021 at 8:28 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 11/01/2021 13:00, H.J. Lu via Libc-alpha wrote:
> > On Fedora 33, I got these new math test failures:
> >
> > FAIL: math/test-double-cosh
> > FAIL: math/test-float32x-cosh
> > FAIL: math/test-float64-cosh
> >
> > for i686 glibc like
> >
> > Failure: cosh_upward (-0x2.c5d374p+12): Exception "Overflow" not set
> > Failure: cosh_upward (-0x2.c5d37700c6bb2p+12): Exception "Overflow" not set
> > Failure: cosh_upward (-0x2.c5d37700c6bbp+12): Exception "Overflow" not set
> > Failure: cosh_upward (-0x2.c5d378p+12): Exception "Overflow" not set
> > Failure: cosh_upward (-0x2.c679d1f73f0fcp+8): Exception "Overflow" not set
> > Failure: cosh_upward (-0x2.c679d4p+8): Exception "Overflow" not set
> > Failure: cosh_upward (-0xf.ffffffffffff8p+1020): Exception "Overflow" not set
> > Failure: cosh_upward (-0xf.fffffp+124): Exception "Overflow" not set
> > Failure: cosh_upward (0x2.c5d374p+12): Exception "Overflow" not set
> > Failure: cosh_upward (0x2.c5d37700c6bb2p+12): Exception "Overflow" not set
> > Failure: cosh_upward (0x2.c5d37700c6bbp+12): Exception "Overflow" not set
> > Failure: cosh_upward (0x2.c5d378p+12): Exception "Overflow" not set
> > Failure: cosh_upward (0x2.c679d1f73f0fcp+8): Exception "Overflow" not set
> > Failure: cosh_upward (0x2.c679d4p+8): Exception "Overflow" not set
> > Failure: cosh_upward (0xf.ffffffffffff8p+1020): Exception "Overflow" not set
> > Failure: cosh_upward (0xf.fffffp+124): Exception "Overflow" not set
>
> This is a regression of BZ#18980 caused by 9e97f239eae1f2b1.  The original
> issue was fixed by c8235dda728c445, but the patch did not add the fix for
> wordsize64 version because it does not require back then (since it seems
> to happen on 32-bit, at least I am seeing on i686).
>
> This seems to fix it:
>
> diff --git a/sysdeps/ieee754/dbl-64/e_cosh.c b/sysdeps/ieee754/dbl-64/e_cosh.c
> index 4f41ca2c92..81de5ae6bd 100644
> --- a/sysdeps/ieee754/dbl-64/e_cosh.c
> +++ b/sysdeps/ieee754/dbl-64/e_cosh.c
> @@ -33,6 +33,7 @@
>
>  #include <math.h>
>  #include <math_private.h>
> +#include <math-narrow-eval.h>
>  #include <libm-alias-finite.h>
>
>  static const double one = 1.0, half=0.5, huge = 1.0e300;
> @@ -80,6 +81,6 @@ __ieee754_cosh (double x)
>         if(ix>=0x7ff00000) return x*x;
>
>      /* |x| > overflowthresold, cosh(x) overflow */
> -       return huge*huge;
> +       return math_narrow_eval (huge * huge);
>  }
>  libm_alias_finite (__ieee754_cosh, __cosh)

It fixed i686.  Can you check it in?

BTW, I also saw random failure:

FAIL: misc/tst-bz21269
[hjl@gnu-skx-1 build-i686-linux]$ cat misc/tst-bz21269.out
Timed out: killed the child process
Termination time: 2021-01-11T18:13:03.494991075
Last write to standard output: 2021-01-11T18:12:43.491654736
[hjl@gnu-skx-1 build-i686-linux]$

Is this a known issue?

Thanks.

-- 
H.J.

  reply	other threads:[~2021-01-11 18:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 16:00 New math test failures on Fedora/33 H.J. Lu via Libc-alpha
2021-01-11 16:28 ` Adhemerval Zanella via Libc-alpha
2021-01-11 18:37   ` H.J. Lu via Libc-alpha [this message]
2021-01-11 19:21     ` Adhemerval Zanella via Libc-alpha
2021-01-12  7:13       ` Paul Zimmermann
2021-01-12 17:29         ` Adhemerval Zanella via Libc-alpha
2021-01-12 17:39           ` Siddhesh Poyarekar
2021-01-12 19:14           ` Tulio Magno Quites Machado Filho via Libc-alpha
2021-01-13  6:34             ` Paul Zimmermann
2021-01-13 12:51               ` Adhemerval Zanella via Libc-alpha
2021-01-14 12:48                 ` Carlos O'Donell via Libc-alpha
2021-01-14 12:59             ` Carlos O'Donell via Libc-alpha
2021-01-14 13:19               ` Paul Zimmermann
2021-01-14 14:47                 ` Carlos O'Donell via Libc-alpha
2021-01-14 13:07 ` Carlos O'Donell via Libc-alpha
  -- strict thread matches above, loose matches on Subject: below --
2021-01-18 14:22 Wilco Dijkstra via Libc-alpha
2021-01-18 14:36 ` Paul Zimmermann
2021-01-18 14:36 ` Andreas Schwab
2021-01-18 15:18   ` Paul Zimmermann
2021-01-18 17:03     ` Andreas Schwab
2021-01-18 15:20   ` Wilco Dijkstra via Libc-alpha
2021-01-18 15:30     ` Carlos O'Donell via Libc-alpha
2021-01-18 15:38       ` Andreas Schwab
2021-01-18 16:58 ` Florian Weimer via Libc-alpha
2021-01-19 15:59 ` Patrick McGehearty via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOpZq1f_4XK89a+wX9Gr3sk5qGxZg4VO5y2BfVg+5E++EQ@mail.gmail.com \
    --to=libc-alpha@sourceware.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).