From: Alistair Francis <alistair23@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>,
"Maciej W. Rozycki" <macro@wdc.com>
Subject: Re: [PATCH v2 2/2] sysdeps/statfs: Handle 64-bit ino_t types on 32-bit hosts
Date: Mon, 23 Sep 2019 16:10:31 -0700 [thread overview]
Message-ID: <CAKmqyKNQDwzshxN9NQTWyn7PXKPEinzhrHupNktbmoWSSx-Fng@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1909192034150.11875@digraph.polyomino.org.uk>
On Thu, Sep 19, 2019 at 1:36 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Wed, 18 Sep 2019, Alistair Francis wrote:
>
> > On a 32-bit platform with a 64-bit ino_t type (__INO_T_MATCHES_INO64_T
> > defined) we want to update the statfs struct to remove the padding as it
> > isn't required. As we don't have the padding we also need to update the
> > overflow checker to not access the undefined members.
>
> I don't think this is anything to do with ino_t (or off_t). It's actually
> about whether fsblkcnt_t matches fsblkcnt64_t and fsfilcnt_t matches
> fsfilcnt64_t. It would seem cleanest for those to get their own macros
> saying whether those types match. Or, more simply, a single macro
> __STATFS_MATCHES_STATFS64.
That makes sense, I have updated this patch.
Alistair
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2019-09-23 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 23:54 [PATCH v2 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts Alistair Francis
2019-09-18 23:54 ` [PATCH v2 2/2] sysdeps/statfs: " Alistair Francis
2019-09-19 20:36 ` Joseph Myers
2019-09-23 23:10 ` Alistair Francis [this message]
2019-09-19 20:33 ` [PATCH v2 1/2] sysdeps/stat: " Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKNQDwzshxN9NQTWyn7PXKPEinzhrHupNktbmoWSSx-Fng@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=macro@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).