From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 550681F463 for ; Mon, 23 Sep 2019 23:11:05 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; q=dns; s=default; b=GRPF IjkZBX9xvAAO01ocZ/MW+BCfPTpousMT3H8pKgOSLBHVklbZLtci0rYMH2APcq2u U7VBRmqZa6j/TJVCqtsj2FViXhSBDNcEfJZNTTDUfiAWFbtREtafflDxvlvSahGY vne5FBVWhPDRcFQML4ToyJ40wtqy6jE9iqYwArE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-type; s=default; bh=bhQ2E9ulY3 vJ+cEvZr+/8mQKa/c=; b=uka8rH+kHzSfR2vDewriL9cpcgpNzaIy9kOSgD6CVv k06bq9YSJ0aowvFAwYXBC9RWnd0RaRI+/i1pRMbdE4LR3wmWCIsx3qNB7oGNtxoO 90joMo84adQZTa/x/WFQgpsDFz2/iQlhU8dHQTvCEtwPU/HRvBbJOPX/lUGI/lvZ 4= Received: (qmail 110867 invoked by alias); 23 Sep 2019 23:11:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 110855 invoked by uid 89); 23 Sep 2019 23:11:02 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-lj1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PG1WKU52lAe11Jn/EnnkHKgL2xAOelutyK/R9SYhOQ4=; b=iasbsJH+FRaOGptJBEJFaaMOGhuAh/DYpgBDKLUuJ9iYuN6jfmEeys1jYpOT6KShD8 tW1gthd/Km0pUj7OKwRxPrZQ95V4thTwjV8jW3SfVVyQ2qVGTKasEUpblQXG3xNJxssQ yYxSje7Gj/nVexHCCtmaMz/lc86pmYzqyfM/p402Qvjmv3xRG37uFCH15NW5QFgurvGq 5TZe0OBq1qlZM2UFCBZ5dEOi45guWDHu6WkCZxXwB1U979CKjMnaIioBduWfv5oLiqP/ yDvW9UFjDleb7UGb4g1rrMgE8KO2dFl1f6PK1RNC4L81i0i1LHrr5AdjhEdZ6zW2PH5H s/aw== MIME-Version: 1.0 References: <20190918235448.5037-1-alistair.francis@wdc.com> <20190918235448.5037-2-alistair.francis@wdc.com> In-Reply-To: From: Alistair Francis Date: Mon, 23 Sep 2019 16:10:31 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] sysdeps/statfs: Handle 64-bit ino_t types on 32-bit hosts To: Joseph Myers Cc: Alistair Francis , GNU C Library , "Maciej W. Rozycki" Content-Type: text/plain; charset="UTF-8" On Thu, Sep 19, 2019 at 1:36 PM Joseph Myers wrote: > > On Wed, 18 Sep 2019, Alistair Francis wrote: > > > On a 32-bit platform with a 64-bit ino_t type (__INO_T_MATCHES_INO64_T > > defined) we want to update the statfs struct to remove the padding as it > > isn't required. As we don't have the padding we also need to update the > > overflow checker to not access the undefined members. > > I don't think this is anything to do with ino_t (or off_t). It's actually > about whether fsblkcnt_t matches fsblkcnt64_t and fsfilcnt_t matches > fsfilcnt64_t. It would seem cleanest for those to get their own macros > saying whether those types match. Or, more simply, a single macro > __STATFS_MATCHES_STATFS64. That makes sense, I have updated this patch. Alistair > > -- > Joseph S. Myers > joseph@codesourcery.com