From: Arjun Shankar <arjun@redhat.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: simon.chopin@canonical.com, "Carlos O'Donell" <carlos@redhat.com>,
libc-alpha@sourceware.org, schwab@suse.de
Subject: Re: [PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations
Date: Mon, 18 Mar 2024 17:07:50 +0100 [thread overview]
Message-ID: <CAG_osaboC-X8HFmqreXkWLaiPovpRHhQBr0bqfupoGdK70ZnaQ@mail.gmail.com> (raw)
In-Reply-To: <mhng-d6686aa3-e686-404f-b4a7-8cab037bb338@palmer-ri-x1c9>
> On Mon, 18 Mar 2024 06:31:00 PDT (-0700), arjun@redhat.com wrote:
> >> I have commit verification turned on by default, which trips up pulling
> >> when there is a non-signed commit at HEAD. There's likely a whole class
> >> of similar configuration issues that could crop up, so this just ignores
> >> user configuration files entirely.
> >>
> >> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> >
> > Looks like this unconditionally sets these environment variables? I'm
> > wondering if this limits other use cases like e.g., users who set
> > these environment variables and expect those values to be used during
> > build-many-glibcs (for whatever reason)?
>
> Ya, I was kind of worried about that too. I've also got a bunch of
> insteadOf lines in my configs, and while I don't know of anything that
> would trip up build-many-glibcs if they disappeared I wouldn't be
> surprised if someone else had a setup that did. That's why the v1 went
> the other way and just tried to override the signature verification for
> the pulls.
>
> IIRC there's some sort of global git config to override per-repo-path
> settings, maybe the right answer is to just do that for whatever test
> paths I have?
While I don't know about other alternatives, looking at your suggested
patch: will setting/exporting GIT_CONFIG_GLOBAL/GIT_CONFIG_NOSYSTEM
before your build_many_glibcs invocation do the trick for you?
prev parent reply other threads:[~2024-03-18 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 0:04 [PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations Palmer Dabbelt
2024-03-13 9:01 ` Andreas Schwab
2024-03-18 13:31 ` Arjun Shankar
2024-03-18 15:41 ` Palmer Dabbelt
2024-03-18 16:07 ` Arjun Shankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG_osaboC-X8HFmqreXkWLaiPovpRHhQBr0bqfupoGdK70ZnaQ@mail.gmail.com \
--to=arjun@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@rivosinc.com \
--cc=schwab@suse.de \
--cc=simon.chopin@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).