From: Palmer Dabbelt <palmer@rivosinc.com>
To: simon.chopin@canonical.com, Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org, Palmer Dabbelt <palmer@rivosinc.com>
Subject: [PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations
Date: Tue, 12 Mar 2024 17:04:30 -0700 [thread overview]
Message-ID: <20240313000429.23213-2-palmer@rivosinc.com> (raw)
I have commit verification turned on by default, which trips up pulling
when there is a non-signed commit at HEAD. There's likely a whole class
of similar configuration issues that could crop up, so this just ignores
user configuration files entirely.
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
This has been pretty lightly tested, but it seems to not be breaking
anything on my end.
Changes since v1 <20240112185846.24483-1-palmer@rivosinc.com/>:
* Ignore the git configs rather than passing "--no-verify-signatures" to
"git pull" commands.
---
scripts/build-many-glibcs.py | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index cc30dd5862..0d06ca1ba4 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -1976,8 +1976,15 @@ def check_for_required_tools():
if count_old_tools > 0 or count_missing_tools > 0:
exit (1);
+def setup_env_vars():
+ # Prevents git from loading configuration files, to avoid tripping over
+ # user settings like --verify-signatures.
+ os.environ["GIT_CONFIG_GLOBAL"] = "/dev/null"
+ os.environ["GIT_CONFIG_NOSYSTEM"] = "1"
+
def main(argv):
"""The main entry point."""
+ setup_env_vars();
check_for_required_tools();
parser = get_parser()
opts = parser.parse_args(argv)
--
2.43.0
next reply other threads:[~2024-03-13 0:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 0:04 Palmer Dabbelt [this message]
2024-03-13 9:01 ` [PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations Andreas Schwab
2024-03-18 13:31 ` Arjun Shankar
2024-03-18 15:41 ` Palmer Dabbelt
2024-03-18 16:07 ` Arjun Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313000429.23213-2-palmer@rivosinc.com \
--to=palmer@rivosinc.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=simon.chopin@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).