From: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 7/8] socket: Add time64 alias for getsockopt
Date: Tue, 20 Jul 2021 11:17:23 +0200 [thread overview]
Message-ID: <87y2a1s5ss.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210720111059.40b6a49d@ktm> (Lukasz Majewski's message of "Tue, 20 Jul 2021 11:10:59 +0200")
* Lukasz Majewski:
>> diff --git a/socket/sys/socket.h b/socket/sys/socket.h
>> index e779dc837f..b37c87e7df 100644
>> --- a/socket/sys/socket.h
>> +++ b/socket/sys/socket.h
>> @@ -251,9 +251,24 @@ extern int __REDIRECT (recvmmsg, (int __fd,
>> struct mmsghdr *__vmessages, /* Put the current value for socket FD's
>> option OPTNAME at protocol level LEVEL into OPTVAL (which is *OPTLEN
>> bytes long), and set *OPTLEN to the value's actual length. Returns 0
>> on success, -1 for errors. */ +#ifndef __USE_TIME_BITS64
>> extern int getsockopt (int __fd, int __level, int __optname,
>> void *__restrict __optval,
>> socklen_t *__restrict __optlen) __THROW;
>> +#else
>
> [*]
>
>> +# ifdef __REDIRECT
>> +extern int __REDIRECT_NTH (getsockopt,
>> + (int __fd, int __level, int __optname,
>> + void *__restrict __optval,
>> + socklen_t *__restrict __optlen),
>> + __getsockopt64);
>> +# else
>> +extern int __getsockopt64 (int __fd, int __level, int __optname,
>> + void *__restrict __optval,
>> + socklen_t *__restrict __optlen) __THROW;
>
> Shouldn't the __getsockopt64() declaration be placed at [*].
I think __REDIRECT_NTH does not need a declaration for the redirection
target.
Thanks,
Florian
next prev parent reply other threads:[~2021-07-20 9:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 13:41 [PATCH 0/8] Additional time64 aliases Florian Weimer via Libc-alpha
2021-07-05 13:41 ` [PATCH 1/8] misc: Add time64 alias for ioctl Florian Weimer via Libc-alpha
2021-07-20 8:32 ` Lukasz Majewski
2021-07-20 8:52 ` Florian Weimer via Libc-alpha
2021-07-20 9:18 ` Lukasz Majewski
2021-07-20 19:47 ` Adhemerval Zanella via Libc-alpha
2021-07-05 13:41 ` [PATCH 2/8] io: Add time64 alias for fcntl Florian Weimer via Libc-alpha
2021-07-20 8:41 ` Lukasz Majewski
2021-07-20 8:45 ` Lukasz Majewski
2021-07-20 8:50 ` Florian Weimer via Libc-alpha
2021-07-20 9:16 ` Lukasz Majewski
2021-07-20 19:49 ` Adhemerval Zanella via Libc-alpha
2021-07-05 13:42 ` [PATCH 3/8] Linux: Add time64 alias for prctl Florian Weimer via Libc-alpha
2021-07-20 8:51 ` Lukasz Majewski
2021-07-20 19:52 ` Adhemerval Zanella via Libc-alpha
2021-07-05 13:42 ` [PATCH 4/8] socket: Add time64 alias for sendmmsg Florian Weimer via Libc-alpha
2021-07-20 8:56 ` Lukasz Majewski
2021-07-20 19:55 ` Adhemerval Zanella via Libc-alpha
2021-07-05 13:42 ` [PATCH 5/8] socket: Add time64 alias for recvmsg Florian Weimer via Libc-alpha
2021-07-20 8:58 ` Lukasz Majewski
2021-07-20 19:56 ` Adhemerval Zanella via Libc-alpha
2021-07-05 13:42 ` [PATCH 6/8] socket: Add time64 alias for sendmsg Florian Weimer via Libc-alpha
2021-07-20 9:02 ` Lukasz Majewski
2021-07-20 20:11 ` Adhemerval Zanella via Libc-alpha
2021-07-05 13:42 ` [PATCH 7/8] socket: Add time64 alias for getsockopt Florian Weimer via Libc-alpha
2021-07-20 9:10 ` Lukasz Majewski
2021-07-20 9:17 ` Florian Weimer via Libc-alpha [this message]
2021-07-20 10:25 ` Lukasz Majewski
2021-07-21 20:09 ` Adhemerval Zanella via Libc-alpha
2021-07-21 20:12 ` Florian Weimer via Libc-alpha
2021-07-21 20:17 ` Adhemerval Zanella via Libc-alpha
2021-07-05 13:42 ` [PATCH 8/8] socket: Add time64 alias for setsockopt Florian Weimer via Libc-alpha
2021-07-20 9:15 ` Lukasz Majewski
2021-07-20 9:18 ` Florian Weimer via Libc-alpha
2021-07-21 20:10 ` Adhemerval Zanella via Libc-alpha
-- strict thread matches above, loose matches on Subject: below --
2021-07-19 15:28 [PATCH v2 0/8] Additional time64 system call wrappers Florian Weimer via Libc-alpha
2021-07-19 15:29 ` [PATCH 7/8] socket: Add time64 alias for getsockopt Florian Weimer via Libc-alpha
2021-07-21 20:19 ` Adhemerval Zanella via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2a1s5ss.fsf@oldenburg.str.redhat.com \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).