From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EC7391F5AE for ; Tue, 20 Jul 2021 09:17:57 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28A4F3988029 for ; Tue, 20 Jul 2021 09:17:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28A4F3988029 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626772677; bh=Np0Q1P7aI/8JiKlwGxB16co9ZG7T4FKQ6cDWD7CWRvY=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UFgWtDxHHfLqQ/3aQcZaT4ahhlc7LervTS3eBHR6n9YNA1HPbGBfiv+/Mcr0L0SKi nT6hOC7jtTwDLQcKN7WwHWOq5qI74BcJPLToGdmKJZDzotA4iv3yjDhZXTS26jmnuO TFwTQsCBBTkMkFNwjFncj0LuroU7ykHBvJk5M8rs= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0B804398A4B7 for ; Tue, 20 Jul 2021 09:17:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B804398A4B7 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-114-DVYP7RNzMwa-73bHOIrTdQ-1; Tue, 20 Jul 2021 05:17:32 -0400 X-MC-Unique: DVYP7RNzMwa-73bHOIrTdQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A08B0804177; Tue, 20 Jul 2021 09:17:26 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-73.phx2.redhat.com [10.3.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C84B760CA1; Tue, 20 Jul 2021 09:17:25 +0000 (UTC) To: Lukasz Majewski Subject: Re: [PATCH 7/8] socket: Add time64 alias for getsockopt References: <539b2c5d20735487ae6c1276f42679dc4ff38ae0.1625492203.git.fweimer@redhat.com> <20210720111059.40b6a49d@ktm> Date: Tue, 20 Jul 2021 11:17:23 +0200 In-Reply-To: <20210720111059.40b6a49d@ktm> (Lukasz Majewski's message of "Tue, 20 Jul 2021 11:10:59 +0200") Message-ID: <87y2a1s5ss.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Cc: Florian Weimer via Libc-alpha Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" * Lukasz Majewski: >> diff --git a/socket/sys/socket.h b/socket/sys/socket.h >> index e779dc837f..b37c87e7df 100644 >> --- a/socket/sys/socket.h >> +++ b/socket/sys/socket.h >> @@ -251,9 +251,24 @@ extern int __REDIRECT (recvmmsg, (int __fd, >> struct mmsghdr *__vmessages, /* Put the current value for socket FD's >> option OPTNAME at protocol level LEVEL into OPTVAL (which is *OPTLEN >> bytes long), and set *OPTLEN to the value's actual length. Returns 0 >> on success, -1 for errors. */ +#ifndef __USE_TIME_BITS64 >> extern int getsockopt (int __fd, int __level, int __optname, >> void *__restrict __optval, >> socklen_t *__restrict __optlen) __THROW; >> +#else > > [*] > >> +# ifdef __REDIRECT >> +extern int __REDIRECT_NTH (getsockopt, >> + (int __fd, int __level, int __optname, >> + void *__restrict __optval, >> + socklen_t *__restrict __optlen), >> + __getsockopt64); >> +# else >> +extern int __getsockopt64 (int __fd, int __level, int __optname, >> + void *__restrict __optval, >> + socklen_t *__restrict __optlen) __THROW; > > Shouldn't the __getsockopt64() declaration be placed at [*]. I think __REDIRECT_NTH does not need a declaration for the redirection target. Thanks, Florian