From: Florian Weimer <fw@deneb.enyo.de>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: RFC: test-in-container vs ld.so
Date: Fri, 08 Nov 2019 08:27:08 +0100 [thread overview]
Message-ID: <87wocavneb.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <xnsgmzqpwp.fsf@greed.delorie.com> (DJ Delorie's message of "Thu, 07 Nov 2019 17:31:50 -0500")
* DJ Delorie:
> So... should we run containerized tests without ld.so?
Yes, absolutely. It's one of the benefits of running things in a
container.
But I think we are already doing that? test-container is run via
ld.so, but the actual test is not?
> 1. Are there tests that *need* the env/ld.so handling within the
> container? (not counting test-specific environment variables, I mean
> the environment variables we pass to *every* test)
We need to set up a predictable locale configuration. But GCONV_PATH
and LOCPATH should *not* be set.
> 2. how complicated would it be to remove those from the makefile
> rules? Alternatively, I suppose test-container itself could remove
> them, but better not to hide that logic.
I suspect the removalof LC_*, LANG etc. variables should be done in
test-container, just for convenience.
Then we can just drop $(run-program-env) because it is defined as:
# $(run-program-env) is the default environment variable settings to
# use when running a program built with the newly built library.
run-program-env = GCONV_PATH=$(common-objpfx)iconvdata \
LOCPATH=$(common-objpfx)localedata LC_ALL=C
next prev parent reply other threads:[~2019-11-08 7:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 22:31 RFC: test-in-container vs ld.so DJ Delorie
2019-11-08 7:27 ` Florian Weimer [this message]
2019-11-08 8:05 ` DJ Delorie
2019-11-08 8:25 ` Florian Weimer
2019-11-08 23:54 ` DJ Delorie
2019-11-09 13:24 ` Carlos O'Donell
2019-11-09 14:05 ` Florian Weimer
2019-12-06 4:19 ` DJ Delorie
2019-12-06 20:09 ` DJ Delorie
2019-12-10 19:33 ` Carlos O'Donell
2019-12-10 19:37 ` DJ Delorie
2019-11-08 15:07 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wocavneb.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).